Use byte for RuleKind and DocKind #7332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saving 7 bytes per index result. Not much, but adds up to ~10Mb in the `regal lint` benchmark. Changing the underlying type is technically a breaking change I suppose, but in the unlikely case anyone used this outside of OPA (we barely use it ourselves!), they'd still have to do and int() conversion to work with it as an int, which will still work. Signed-off-by: Anders Eknert <[email protected]>
srenatus
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving 7 bytes per index result. Not much, but adds up to ~10Mb in the
regal lintbenchmark. Changing the underlying type is technically a breaking change I suppose, but in the unlikely case anyone used this outside of OPA (we barely use it ourselves!), they'd still have to do and int() conversion to work with it as an int, which will still work.