Add perfsprint linter #7334
Merged
Add perfsprint linter #7334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And update code to conform to the rule. - Replace unnecessary fmt.Sprintf with string concatenation - Replace fmt.Sprint with more efficient strconv.Itoa - Replace static fmt.Errorf calls with more efficient errors.New Thanks @srenatus for pushing me down this rabbit hole! Signed-off-by: Anders Eknert <[email protected]>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
right hand approve pull request, left hand shrug shoulder |
srenatus
approved these changes
Jan 31, 2025
| @@ -1745,7 +1745,7 @@ func (e *evalResolver) Resolve(ref ast.Ref) (ast.Value, error) { | |||
| return merged, err | |||
| } | |||
| e.e.instr.stopTimer(evalOpResolve) | |||
| return nil, fmt.Errorf("illegal ref") | |||
| return nil, errors.New("illegal ref") | |||
There was a problem hiding this comment.
💭 well that's a lot, I might have only applied it to topdown/eval.go where it really matters. Oh let's see what it did to eval.go
....
😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And update code to conform to the rule.
Thanks @srenatus for pushing me down this rabbit hole.
The joke's on you now that you have to review this!