perf: use GetByValue to avoid boxing to interface{} #7372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And make shorthand types boxed types to avoid allocations at runtime. Below stats show the difference running Regal lint with all rules disabled (to better highlight compilation costs). @srenatus will be pleased by this format, I'm sure. ``` goos: darwin goarch: arm64 pkg: github.com/styrainc/regal/pkg/linter cpu: Apple M4 Pro │ main.txt │ pr.txt │ │ sec/op │ sec/op vs base │ RegalNoEnabledRules-12 190.8m ± 2% 181.8m ± 2% -4.72% (p=0.002 n=6) │ main.txt │ pr.txt │ │ B/op │ B/op vs base │ RegalNoEnabledRules-12 474.4Mi ± 0% 471.3Mi ± 0% -0.65% (p=0.002 n=6) │ main.txt │ pr.txt │ │ allocs/op │ allocs/op vs base │ RegalNoEnabledRules-12 9.657M ± 0% 9.476M ± 0% -1.88% (p=0.002 n=6) ``` Signed-off-by: Anders Eknert <[email protected]>
anderseknert
commented
Feb 18, 2025
| ref = append(ref, dynamicSuffix[i]) | ||
| } | ||
| rule.Head.SetRef(ref) | ||
| rule.Head.SetRef(append(ref, dynamicSuffix...)) |
There was a problem hiding this comment.
This is unrelated but suggested by a later version of golangci-lint, which was nice :)
anderseknert
commented
Feb 18, 2025
| @@ -131,7 +131,7 @@ func (w *compressResponseWriter) doCompressedResponse() error { | |||
| w.Header().Del(contentLengthHeader) | |||
| w.writeHeader() | |||
| // there's nothing to write | |||
| if w.buffer == nil || len(w.buffer) <= 0 { | |||
| if len(w.buffer) <= 0 { | |||
johanfylling
approved these changes
Feb 18, 2025
| tpe := types.Keys(rc.env.getRefRecExtent(node)) | ||
| if exist := rc.env.Get(v); exist != nil { | ||
| if exist := rc.env.GetByValue(head.Value); exist != nil { |
There was a problem hiding this comment.
In a lot of places, we're pulling the value out of a term; enough to warrant a GetByRef()/GetByRefValue()?
There was a problem hiding this comment.
You mean we should accept a *Term instead of a Value? I'm generally in favor of accepting the least common denominator, which in this case would be the value... and we'd still need GetByRef (which we did before as well, it was just internal).
| @@ -518,7 +518,7 @@ func TestCheckInferenceRules(t *testing.T) { | |||
| {"ref_regression_array_key", ruleset2, "data.ref_regression_array_key.walker", | |||
| types.NewObject( | |||
| nil, | |||
| types.NewDynamicProperty(types.NewArray([]types.Type{types.NewArray(types.A, types.A), types.A}, nil), | |||
| types.NewDynamicProperty(types.NewArray([]types.Type{types.NewArray(types.NewAny(), types.A), types.A}, nil), | |||
There was a problem hiding this comment.
types.A now represents the boxed Type (interface) of Any rather than Any ([]Type), and in the case of types.NewArray, the latter was expected.
// Any represents a dynamic type.
type Any []Type
// A represents the superset of all types.
var A Type = NewAny()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And make shorthand types boxed types to avoid allocations at runtime.
Below stats show the difference running Regal lint with all rules disabled (to better highlight compilation costs). @srenatus will be pleased by this format, I'm sure.