Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Reduce port contention in service tests #12616

Merged

Conversation

evan-bradley
Copy link
Contributor

Description

I noticed the service tests were a little flaky due to using the default Prometheus port. This should at least reduce the frequency where this happens if not eliminate it.

I did two things to help elimination contention for the port:

  1. Disable the Prometheus server in tests where it isn't needed.
  2. Ensure the port is randomized in tests where it is needed.

@evan-bradley evan-bradley requested a review from a team as a code owner March 11, 2025 22:10
@evan-bradley evan-bradley requested a review from jpkrohling March 11, 2025 22:10
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (d3c5895) to head (b455129).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12616      +/-   ##
==========================================
+ Coverage   92.16%   92.19%   +0.02%     
==========================================
  Files         471      471              
  Lines       25561    25561              
==========================================
+ Hits        23558    23565       +7     
+ Misses       1591     1586       -5     
+ Partials      412      410       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@codeboten codeboten added this pull request to the merge queue Mar 12, 2025
Merged via the queue into open-telemetry:main with commit 09919ab Mar 12, 2025
47 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants