Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetrysdk resource to cart service #497

Merged
merged 13 commits into from
Oct 20, 2022
Merged

Add telemetrysdk resource to cart service #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1bed796
Add runtime metrics to cartservice
cijothomas Sep 29, 2022
e51e249
reorder
cijothomas Sep 29, 2022
888c38b
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
cijothomas Sep 29, 2022
920a365
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
cijothomas Oct 19, 2022
aa99792
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
cijothomas Oct 19, 2022
7f033f0
Add telemetrysdk resource to cart service
cijothomas Oct 20, 2022
b67beb6
nit rever
cijothomas Oct 20, 2022
c5ed339
Merge branch 'main' into cijothomas/cart-addresource
cijothomas Oct 20, 2022
b75d1d4
new hosting
cijothomas Oct 20, 2022
0766c80
Merge branch 'cijothomas/cart-addresource' of https://github.com/cijo…
cijothomas Oct 20, 2022
0009c29
add to doc
cijothomas Oct 20, 2022
3a33f80
Merge branch 'main' into cijothomas/cart-addresource
cijothomas Oct 20, 2022
4016604
Merge branch 'main' into cijothomas/cart-addresource
cijothomas Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions docs/services/cartservice.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,15 @@ of this initialization. Resource attributes and exporter endpoint are
automatically read from OpenTelemetry standard environment variables.

```cs
services.AddOpenTelemetryTracing((builder) => builder
.AddRedisInstrumentation(
cartStore.GetConnection(),
options => options.SetVerboseDatabaseStatements = true)
.AddAspNetCoreInstrumentation()
.AddGrpcClientInstrumentation()
.AddHttpClientInstrumentation()
.AddOtlpExporter());
services.AddOpenTelemetryTracing((builder) => builder
.ConfigureResource(r => r.AddTelemetrySdk())
.AddRedisInstrumentation(
cartStore.GetConnection(),
options => options.SetVerboseDatabaseStatements = true)
.AddAspNetCoreInstrumentation()
.AddGrpcClientInstrumentation()
.AddHttpClientInstrumentation()
.AddOtlpExporter());
```

Note:
Expand Down Expand Up @@ -69,10 +70,11 @@ of this initialization. Resource attributes and exporter endpoint are
automatically read from OpenTelemetry standard environment variables.

```cs
services.AddOpenTelemetryMetrics(builder =>
builder.AddRuntimeInstrumentation()
.AddAspNetCoreInstrumentation()
.AddOtlpExporter());;
services.AddOpenTelemetryMetrics(builder => builder
.ConfigureResource(r => r.AddTelemetrySdk())
.AddRuntimeInstrumentation()
.AddAspNetCoreInstrumentation()
.AddOtlpExporter());
```

## Logs
Expand Down
11 changes: 7 additions & 4 deletions src/cartservice/src/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Diagnostics.HealthChecks;
using OpenTelemetry.Metrics;
using OpenTelemetry.Resources;
using OpenTelemetry.Trace;
using cartservice.services;
using Microsoft.AspNetCore.Http;
Expand All @@ -41,6 +42,7 @@
builder.Services.AddSingleton<ICartStore>(cartStore);

builder.Services.AddOpenTelemetryTracing((builder) => builder
.ConfigureResource(r => r.AddTelemetrySdk())
.AddRedisInstrumentation(
cartStore.GetConnection(),
options => options.SetVerboseDatabaseStatements = true)
Expand All @@ -49,10 +51,11 @@
.AddHttpClientInstrumentation()
.AddOtlpExporter());

builder.Services.AddOpenTelemetryMetrics(builder =>
builder.AddRuntimeInstrumentation()
.AddAspNetCoreInstrumentation()
.AddOtlpExporter());
builder.Services.AddOpenTelemetryMetrics(builder => builder
.ConfigureResource(r => r.AddTelemetrySdk())
.AddRuntimeInstrumentation()
.AddAspNetCoreInstrumentation()
.AddOtlpExporter());

builder.Services.AddGrpc();
builder.Services.AddGrpcHealthChecks()
Expand Down
2 changes: 1 addition & 1 deletion src/cartservice/src/cartservice.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<PackageReference Include="Grpc.AspNetCore.HealthChecks" Version="2.46.0" />
<PackageReference Include="StackExchange.Redis" Version="2.5.43" />
<PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.3.1" />
<PackageReference Include="OpenTelemetry.Extensions.Hosting" Version="1.0.0-rc9.4" />
<PackageReference Include="OpenTelemetry.Extensions.Hosting" Version="1.0.0-rc9.8" />
<PackageReference Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.0.0-rc9.4" />
<PackageReference Include="OpenTelemetry.Instrumentation.GrpcNetClient" Version="1.0.0-rc9.4" />
<PackageReference Include="OpenTelemetry.Instrumentation.Http" Version="1.0.0-rc9.4" />
Expand Down