Revert TraceContextPropagator performance refactor from 5749 #6161
+28
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pkg:OpenTelemetry.Api
cijothomas
reviewed
Mar 3, 2025
cijothomas
approved these changes
Mar 3, 2025
cijothomas
approved these changes
Mar 3, 2025
Kielek
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
@rajkumar-rangaraj, can we make a release 11.1.2 when this one is merged?
I think that we have 2 good reasons (fixes) for this.
Yes, we should discuss in tomorrow's SIG and plan on immediate release. |
rajkumar-rangaraj
approved these changes
Mar 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6161 +/- ##
==========================================
- Coverage 86.34% 86.30% -0.05%
==========================================
Files 257 257
Lines 11557 11499 -58
==========================================
- Hits 9979 9924 -55
+ Misses 1578 1575 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6158
Changes
As discussed in #6158, this reverts to previous performance optimizations until we have added more tests and hardened the implementation.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)