Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leverage native async trait in MetricsClient #2672

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

gruebel
Copy link
Member

@gruebel gruebel commented Feb 15, 2025

Relates #2517

Changes

  • I think this is the last asyn_trait we can remove. there is still some usage around HttpClient trait, but this one is used quite often with dynamic dispatch and this can't be handled by the native async capabilities.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@gruebel gruebel requested a review from a team as a code owner February 15, 2025 11:04
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 79.1%. Comparing base (06ca4a1) to head (5cf2164).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-otlp/src/metric.rs 0.0% 21 Missing ⚠️
opentelemetry-otlp/src/exporter/http/mod.rs 0.0% 1 Missing ⚠️
opentelemetry-otlp/src/exporter/tonic/mod.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2672     +/-   ##
=======================================
- Coverage   79.2%   79.1%   -0.1%     
=======================================
  Files        122     122             
  Lines      22530   22546     +16     
=======================================
  Hits       17853   17853             
- Misses      4677    4693     +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you.

@cijothomas cijothomas merged commit a9a5cbf into open-telemetry:main Feb 15, 2025
20 of 21 checks passed
@gruebel gruebel deleted the improve-metric-client branch February 15, 2025 20:08
cijothomas pushed a commit to cijothomas/opentelemetry-rust that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants