-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(trace): add TelemetryResourceDetector #899
feat(trace): add TelemetryResourceDetector #899
Conversation
Codecov ReportBase: 67.0% // Head: 66.9% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #899 +/- ##
=======================================
- Coverage 67.0% 66.9% -0.1%
=======================================
Files 114 115 +1
Lines 8928 8935 +7
=======================================
- Hits 5989 5986 -3
- Misses 2939 2949 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One minor comment.
impl ResourceDetector for TelemetryResourceDetector { | ||
fn detect(&self, _timeout: Duration) -> Resource { | ||
Resource::new(vec![ | ||
KeyValue::new("telemetry.sdk.name", "opentelemetry"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KeyValue::new("telemetry.sdk.name", "opentelemetry"), | |
KeyValue::new("telemetry.sdk.name", "opentelemetry-sdk"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call out, but the spec asks all opentelemetry provided SDK to use opentelemetry
as the value for this key
The default OpenTelemetry SDK provided by the OpenTelemetry project MUST set telemetry.sdk.name to the value opentelemetry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment could honestly be done in a follow up.
open-telemetry/opentelemetry-demo#504 needs to add
telemetry.sdk.*
info to the resources