Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[demo/cartservice] Avoid warning - hiding variables #2875

Merged
merged 1 commit into from
Jun 15, 2023
Merged

[demo/cartservice] Avoid warning - hiding variables #2875

merged 1 commit into from
Jun 15, 2023

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Jun 15, 2023 •
edited
Loading

@Kielek Kielek mentioned this pull request Jun 15, 2023
Merged
1 task
@Kielek Kielek marked this pull request as ready for review June 15, 2023 05:45
@Kielek Kielek requested review from a team June 15, 2023 05:45
svrnm
svrnm approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kielek let us know when the other PR is merged so we can merge this one (wondering if there is some way to automate that?)

@Kielek
Copy link
Contributor Author

Kielek commented Jun 15, 2023

The demo requires to adjust documentation first (in PR template). I suppose it is sufficient check for .NET service (I do no see any upcoming adjustment in short term).

I think that we can merge this as is right now. It is pretty independent snippet.

@svrnm
Copy link
Member

svrnm commented Jun 15, 2023

The demo requires to adjust documentation first (in PR template). I suppose it is sufficient check for .NET service (I do no see any upcoming adjustment in short term).

I think that we can merge this as is right now. It is pretty independent snippet.

cool then let me do that :-)

@svrnm svrnm merged commit 4322a35 into open-telemetry:main Jun 15, 2023
@Kielek Kielek deleted the demo-cartservice-avoid-hiding-variables branch June 15, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kielek @svrnm