-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch jsonschema validation libraries #1189
Switch jsonschema validation libraries #1189
Conversation
Signed-off-by: Brandon Mitchell <[email protected]>
085bebd
to
4bbdd7f
Compare
I would also keep a fork of this dep under OCI repos because the author may:
|
I think most of those concerns are covered by individual developers with the go module cache on their machines, in addition to Google's Go proxy server: https://sum.golang.org/. |
just a quick comment that Google's Go proxy server is NOT a safeguard against such events; it's a caching proxy, but cache expires after 6 Months. Consider it a protection against repository going AWOL with a grace-period. FWIW, we have had situations where that happened; at least in one case the upstream (one of Microsoft's repositories) decided to "start a new implementation from scratch" and to force-push the repository with new code. Another case was where the upstream repository went AWOL (or vanity domain expired), which was discovered early by us because we used From Google's proxy server; https://proxy.golang.org/#faq-retention
So while https://sum.golang.org/ may keep the checksum, it may still be relevant to have a fork of the code to be able to add a |
This swaps out https://github.com/xeipuuv/gojsonschema for https://github.com/santhosh-tekuri/jsonschema. Considering how far back some of this code goes, feedback from @stevvooe and @vbatts would be awesome.