Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify workflow triggers and status badge #1251

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ScottBrenner
Copy link

Copy link
Contributor

@sudo-bmitch sudo-bmitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this badge is broken because we don't run the workflow on a push to main, only on PRs. I don't think the badge should show a fail if we get a bad PR. Instead we should either remove the badge, or (my preference) update the workflow to run on a push to main. E.g.

on:
  push:
    branches: [ 'main' ]
    tags: [ 'v*.*.*' ]
  pull_request:
    branches: [ 'main' ]

Signed-off-by: Scott Brenner <[email protected]>
Signed-off-by: Scott Brenner <[email protected]>
@ScottBrenner
Copy link
Author

Updated the badge to display the main branch, modified workflow trigger as suggested too ✅

@ScottBrenner ScottBrenner requested a review from sudo-bmitch March 9, 2025 21:04
@ScottBrenner ScottBrenner changed the title Correst status badge in README.md Correct status badge in README.md Mar 9, 2025
@ScottBrenner ScottBrenner changed the title Correct status badge in README.md Modify workflow triggers and status badge Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants