Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: Punt mediaType, size, and digest to descriptor docs #167

Merged
merged 2 commits into from
Jul 22, 2016

Conversation

wking
Copy link
Contributor

@wking wking commented Jul 2, 2016

1149fac (manifest: use descriptor doc as canonical source, 2016-06-15, #143) was a step in this direction. But we can DRY things up a bit more by punting those three properties entirely and just saying "it's a descriptor", and then listing extensions, if any.

wking added 2 commits July 1, 2016 22:21
1149fac (manifest: use descriptor doc as canonical source,
2016-06-15, opencontainers#143) was a step in this direction.  But we can DRY things
up a bit more by punting those three properties entirely and just
saying "it's a descriptor", and then listing extensions, if any.

Signed-off-by: W. Trevor King <[email protected]>
The tab came in with the line in fa4c6e7 (Minor tweaks to manifest
for clarity, 2016-05-06, opencontainers#68), but the rest of this file indents with
spaces.

Signed-off-by: W. Trevor King <[email protected]>
@wking wking force-pushed the manifest-doc-lean-on-descriptor branch from 6322c72 to 56629bb Compare July 2, 2016 05:23
@wking
Copy link
Contributor Author

wking commented Jul 2, 2016

Also a drive-by tab fix.

@vbatts
Copy link
Member

vbatts commented Jul 5, 2016

seems fine to me

@stevvooe
Copy link
Contributor

stevvooe commented Jul 7, 2016

LGTM

Approved with PullApprove

1 similar comment
@brendandburns
Copy link

brendandburns commented Jul 22, 2016

LGTM

Approved with PullApprove

@stevvooe stevvooe added this to the v0.4.0 milestone Jul 22, 2016
@stevvooe stevvooe merged commit e3a1166 into opencontainers:master Jul 22, 2016
@wking wking deleted the manifest-doc-lean-on-descriptor branch July 27, 2016 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants