schema: urls optimization #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevvooe
reviewed
Feb 14, 2017
schema/defs-image.json
Outdated
| @@ -11,6 +11,14 @@ | |||
| "type": "string", | |||
| "pattern": "^[a-z0-9_+.-]+:[a-f0-9]+$" | |||
| }, | |||
| "urls": { | |||
There was a problem hiding this comment.
This should be centralized in the descriptor type, not the image type.
zhouhao3
force-pushed
the
urls-ompt
branch
12 times, most recently
from
1d23619 to
e9c947e
Compare
zhouhao3
force-pushed
the
urls-ompt
branch
2 times, most recently
from
83d9585 to
20ad7f7
Compare
|
LGTM |
|
Needs a rebase. |
jbouzane
approved these changes
Mar 8, 2017
|
@jbouzane, I see you approved this PR, but PullApprove doesn't count that as a LGTM unless you use their v2 config (which we aren't). If folks want to switch to a v2 config, I've taken a stab at one in opencontainers/project-template#29 and am happy to land any pieces of that in whatever repository folks want if they don't want to land it in project-template. Until that happens, you should probably stick to LGTM/Rejected/etc. comments if you want PullApprove to notice. |
added 2 commits
March 9, 2017 09:24
Signed-off-by: zhouhao <[email protected]>
Signed-off-by: zhouhao <[email protected]>
|
updated,PTAL |
|
lgtm |
|
LGTM |
This was referenced Mar 15, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhouhao [email protected]