Makefile: suitable "default" target #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
wking
reviewed
Feb 14, 2017
Makefile
Outdated
| @@ -40,7 +40,7 @@ DOC_FILENAME ?= oci-image-spec | |||
|
|
|||
| EPOCH_TEST_COMMIT ?= v0.2.0 | |||
|
|
|||
| default: help | |||
| default: check-license validate-examples lint test | |||
There was a problem hiding this comment.
validate-examples is a subset of test, so we can drop it from the list of prereqs here.
I like that there is a "help" target, but the default ought to do sensible things. :-) Signed-off-by: Vincent Batts <[email protected]>
vbatts
force-pushed
the
makefile_default_target
branch
from
967ce1c to
7f59691
Compare
|
updated. PTAL |
|
LGTM |
1 similar comment
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like that there is a "help" target, but the default ought to do
sensible things. :-)
Signed-off-by: Vincent Batts [email protected]