Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.md: Sentence modification #629

Merged
merged 1 commit into from
Apr 3, 2017

Conversation

zhouhao3
Copy link

Signed-off-by: zhouhao [email protected]

config.md Outdated
@@ -59,7 +59,7 @@ Defining `|` as a binary application operator, the root filesystem may be `A|B|C
While it is implied that `C` is only useful when applied to `A|B`, the identifier `C` is insufficient to identify this result, as we'd have the equality `C = A|B|C`, which isn't true.

The main issue is when we have two definitions of `C`, `C = C` and `C = A|B|C`.
If this is true (with some handwaving), `C = x|C` where `x = any application` must be true.
If this is true (with some handwaving), `C = x|C` where `x = any application` MUST be true.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a compliance-requirement, so I don't think we need MUST. It's intended to be a mathematical assertion, which has no compliance impact (i.e. there will be no certification testing to check this). Perhaps we should rephrase the sentence to avoid “must”? Maybe:

If this is true (with some handwaving), then C = x|C is true where x = any application.

That would be the narrow fix, although I'm still partial to #593 as a broader simplification.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just is also true would work here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO combine the two:

If this is true (with some handwaving), then C = x|C is true where x = any application.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

@stevvooe
Copy link
Contributor

This isn't a binding specification statement.

@zhouhao3 zhouhao3 changed the title config.md: change must to MUST config.md: Sentence modification Apr 3, 2017
@jonboulle
Copy link
Contributor

jonboulle commented Apr 3, 2017

LGTM

Approved with PullApprove

1 similar comment
@stevvooe
Copy link
Contributor

stevvooe commented Apr 3, 2017

LGTM

Approved with PullApprove

@stevvooe stevvooe merged commit 6f18134 into opencontainers:master Apr 3, 2017
@zhouhao3 zhouhao3 deleted the fix-config-must branch April 5, 2017 01:07
@vbatts vbatts mentioned this pull request May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants