Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image-index: mark os.version, os.features and variant as "reserved" #632

Closed
wants to merge 1 commit into from
Closed

image-index: mark os.version, os.features and variant as "reserved" #632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions image-index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,15 @@ For the media type(s) that this document is compatible with, see the [matrix][ma

- **`os.version`** *string*

This OPTIONAL property specifies the operating system version, for example `10.0.10586`.
This OPTIONAL property is *reserved* for future versions of the specification and hence SHOULD NOT be used.

- **`os.features`** *array of strings*

This OPTIONAL property specifies an array of strings, each specifying a mandatory OS feature (for example on Windows `win32k`).
This OPTIONAL property is *reserved* for future versions of the specification and hence SHOULD NOT be used.

- **`variant`** *string*

This OPTIONAL property specifies the variant of the CPU, for example `armv6l` to specify a particular CPU variant of the ARM CPU.
This OPTIONAL property is *reserved* for future versions of the specification and hence SHOULD NOT be used.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want this for supporting image on arm


- **`features`** *array of strings*

Expand Down
9 changes: 5 additions & 4 deletions specs-go/v1/descriptor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,16 @@ type Platform struct {
OS string `json:"os"`

// OSVersion is an optional field specifying the operating system
// version, for example `10.0.10586`.
// version. This property is reserved and SHOULD NOT be used.
OSVersion string `json:"os.version,omitempty"`

// OSFeatures is an optional field specifying an array of strings,
// each listing a required OS feature (for example on Windows `win32k`).
// each listing a required OS feature. This property is reserved and
// SHOULD NOT be used.
OSFeatures []string `json:"os.features,omitempty"`

// Variant is an optional field specifying a variant of the CPU, for
// example `ppc64le` to specify a little-endian version of a PowerPC CPU.
// Variant is an optional field specifying a variant of the CPU.
// This property is reserved and SHOULD NOT be used.
Variant string `json:"variant,omitempty"`

// Features is an optional field specifying an array of strings, each
Expand Down