specs-go/v1/config: pointer-ify optional "Created" field #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR opencontainers#534 changed Created from string to time.Time field. This neutered the `omitempty` property on it, as a missing field is now populated as the default time.Time value. This commit turns the field into a pointer, in order to keep the empty-value semantic for `omitempty`. Fixes opencontainers#626 Signed-off-by: Luca Bruno <[email protected]>
|
/cc @jonboulle @wking @stevvooe for an ad-hoc review, as per #625 (comment). |
|
LGTM in itself; did you check for any other references to this field? |
|
I grep'd this repo before commiting, and I haven't see anything else. The original PR also only touched those two lines. I don't know if there are any other repos dependent on this. |
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #534 changed Created from string to time.Time field.
This neutered the
omitemptyproperty on it, as a missingfield is now populated as the default time.Time value.
This commit turns the field into a pointer, in order to keep
the empty-value semantic for
omitempty.Fixes #626
Signed-off-by: Luca Bruno [email protected]