Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: reference common label conventions #635

Closed
wants to merge 1 commit into from

Conversation

vbatts
Copy link
Member

@vbatts vbatts commented Apr 3, 2017

This has come up a couple of times on the weekly discussion, but the PR
had not been followed through with.

label-schema.org is a convention that follows the practices outlined in
OCI. Provide here only as a reference example of label usage.

Signed-off-by: Vincent Batts [email protected]

@vbatts
Copy link
Member Author

vbatts commented Apr 3, 2017

cc @lizrice

@wking
Copy link
Contributor

wking commented Apr 3, 2017 via email

@jonboulle
Copy link
Contributor

Why not annotations too?

@vbatts
Copy link
Member Author

vbatts commented Apr 4, 2017 via email

@jonboulle
Copy link
Contributor

I suppose (IMHO) we still haven't clearly described the use cases for one vs the other.

@stevvooe
Copy link
Contributor

stevvooe commented Apr 4, 2017

@vbatts I've filed #636 to bring the OCI annotations/labels to feature parity with label-schema, minus the docker/rkt.cmd stuff.

In general, these style of annotations work best when sitting on the actual image config, rather than manifests or indexes. They can be "pulled up", which makes them indexed, in a sense, but pushing them down to the image config minimizes the possibility of them being lost in transit.

It would be good to add this line:

Labels SHOULD use the annotations defined in annotations.md.

@vbatts
Copy link
Member Author

vbatts commented Apr 4, 2017 via email

@stevvooe
Copy link
Contributor

stevvooe commented Apr 4, 2017

@vbatts Yes, but it seems better if we just have them defined here. I am not saying remove the reference, just point them towards using the annotations. #636 ensures we have all the equivalent annotations from label-schema.

In that vein, I see this PR being the following:

Labels SHOULD use the annotations defined in annotations.md.
There are community conventions available for image labels, for example Label Schema.

@vbatts
Copy link
Member Author

vbatts commented Apr 5, 2017

@stevvooe I see. Perhaps I'll do that in a separate PR because the label rules could just point to ./annotations.md#rules

vbatts added a commit to vbatts/oci-image-spec that referenced this pull request Apr 5, 2017
from
opencontainers#635 (comment)
it was clear that all the rules for `Labels` are the same as
annotations, so let's DRY that up a bit.

Signed-off-by: Vincent Batts <[email protected]>
@wking
Copy link
Contributor

wking commented Apr 5, 2017

Yes, but it seems better if we just have them defined here. I am not saying remove the reference, just point them towards using the annotations. #636 ensures we have all the equivalent annotations from label-schema.

I don't see the point to having OCI-named “equivalent annotations” for keys that don't directly impact image-spec or runtime-spec use-cases. So if we expect to have image-spec or image-tools code acting on the keys, having an OCI-named key makes sense. But I don't see any OCI-repo use-case for “packaged sofware version” (and the goal seems to be just human-readable anyway), so adding OCI-named keys seems like a needless community fragmentation. Why would users want to use the OCI-named keys when they could use the existing org.label-schema.version, etc.? And having to support both in tooling seems like tedious busywork for no practical gain.

@vbatts
Copy link
Member Author

vbatts commented Apr 5, 2017

@wking conversation for the other thread (#636), but agreed

This has come up a couple of times on the weekly discussion, but the PR
had not been followed through with.

label-schema.org is a convention that follows the practices outlined in
OCI. Provide here only as a reference example of label usage.

Signed-off-by: Vincent Batts <[email protected]>
@vbatts
Copy link
Member Author

vbatts commented Apr 12, 2017

rebased (moved stuff to annotations.md to keep DRY)

@stevvooe
Copy link
Contributor

stevvooe commented May 2, 2017

@vbatts Does this need to be modified after #636? Do you want to carry this for the compatibility table?

@vbatts
Copy link
Member Author

vbatts commented May 3, 2017

@stevvooe i reckon a compatibility table would cover any references that this PR would be attempting to achieve.

@vbatts vbatts closed this May 3, 2017
@vbatts vbatts deleted the label-schema branch May 3, 2017 14:37
jonboulle pushed a commit to jonboulle/image-spec that referenced this pull request May 22, 2017
from
opencontainers#635 (comment)
it was clear that all the rules for `Labels` are the same as
annotations, so let's DRY that up a bit.

Signed-off-by: Vincent Batts <[email protected]>
dattgoswami9lk5g added a commit to dattgoswami9lk5g/bremlinr that referenced this pull request Jun 6, 2022
from
opencontainers/image-spec#635 (comment)
it was clear that all the rules for `Labels` are the same as
annotations, so let's DRY that up a bit.

Signed-off-by: Vincent Batts <[email protected]>
7c00d pushed a commit to 7c00d/J1nHyeockKim that referenced this pull request Jun 6, 2022
from
opencontainers/image-spec#635 (comment)
it was clear that all the rules for `Labels` are the same as
annotations, so let's DRY that up a bit.

Signed-off-by: Vincent Batts <[email protected]>
7c00d added a commit to 7c00d/J1nHyeockKim that referenced this pull request Jun 6, 2022
from
opencontainers/image-spec#635 (comment)
it was clear that all the rules for `Labels` are the same as
annotations, so let's DRY that up a bit.

Signed-off-by: Vincent Batts <[email protected]>
laventuraw added a commit to laventuraw/Kihara-tony0 that referenced this pull request Jun 6, 2022
from
opencontainers/image-spec#635 (comment)
it was clear that all the rules for `Labels` are the same as
annotations, so let's DRY that up a bit.

Signed-off-by: Vincent Batts <[email protected]>
tomalopbsr0tt added a commit to tomalopbsr0tt/fabiojosej that referenced this pull request Oct 6, 2022
from
opencontainers/image-spec#635 (comment)
it was clear that all the rules for `Labels` are the same as
annotations, so let's DRY that up a bit.

Signed-off-by: Vincent Batts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants