config.md: small fixes #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mashimiao
force-pushed
the
config-small-fix
branch
from
00fb55d to
fac8c72
Compare
double quotes are not necessary when setting env value and other sentences fix Signed-off-by: Ma Shimiao <[email protected]>
Mashimiao
force-pushed
the
config-small-fix
branch
from
fac8c72 to
f8af5bc
Compare
|
LGTM |
stevvooe
reviewed
May 11, 2017
| @@ -132,24 +132,24 @@ Note: Any OPTIONAL field MAY also be set to null, which is equivalent to being a | |||
|
|
|||
| - **Env** *array of strings*, OPTIONAL | |||
|
|
|||
| Entries are in the format of `VARNAME="var value"`. | |||
There was a problem hiding this comment.
This is actually a good catch. These are NOT quoted.
Good job!
stevvooe
reviewed
May 11, 2017
| These values act as defaults and are merged with any specified when creating a container. | ||
|
|
||
| - **Entrypoint** *array of strings*, OPTIONAL | ||
|
|
||
| A list of arguments to use as the command to execute when the container starts. | ||
| This value acts as a default and is replaced by an entrypoint specified when creating a container. | ||
| These values act as default and are replaced by an entrypoint specified when creating a container. |
| These values act as defaults and are merged with any specified when creating a container. | ||
|
|
||
| - **Entrypoint** *array of strings*, OPTIONAL | ||
|
|
||
| A list of arguments to use as the command to execute when the container starts. | ||
| This value acts as a default and is replaced by an entrypoint specified when creating a container. | ||
| These values act as default and are replaced by an entrypoint specified when creating a container. |
stevvooe
reviewed
May 11, 2017
|
|
||
| - **Cmd** *array of strings*, OPTIONAL | ||
|
|
||
| Default arguments to the entrypoint of the container. | ||
| These values act as defaults and are replaced with any specified when creating a container. | ||
| These values act as defaults and are replaced by any specified when creating a container. |
|
LGTM @Mashimiao I'm going to merge this, but please fix the items in a follow up. |
|
OK, fixed in #673 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
double quotes are not necessary when setting env value
Signed-off-by: Ma Shimiao [email protected]