Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for multiple authors #745

Closed
wants to merge 1 commit into from

Conversation

taqtiqa-mark
Copy link

Arises where a container is a composition of several containers. See Buildah issue #591 specifically the current use case given in comment

Arises where a container is a composition of several containers. See Buildah issue opencontainers#591 specifically the current use case given in [comment](containers/buildah#591 (comment))
@taqtiqa-mark
Copy link
Author

Will add "Signed-off-by"

@wking
Copy link
Contributor

wking commented Apr 17, 2018

You can already use the free-form org.opencontainers.image.authors anywhere that takes annotations (which is at least indexes, manifests, and descriptors). I think that covers all image-spec Merkle trees.

@taqtiqa-mark
Copy link
Author

Thanks for the heads-up. Still feeling my way a little.....

Does that mean the Config:Properties should be updated to be consistent with the pre-defined annotation keys. For example vendor, revision, version are not mentioned in Config:Properties?

@wking
Copy link
Contributor

wking commented Apr 17, 2018

Does that mean the Config:Properties should be updated to be consistent with the pre-defined annotation keys. For example vendor, revision, version are not mentioned in Config:Properties?

My impression is that the config properties are deprecated properties which are kept around for backwards compat, and that new metadata should go into annotations. But I'm not sure how widely supported those annotations are in tooling. Are they checked in the absence of the analogous config property? How do tools handle both being set? Is setting org.opencontainers.image.authors on the manifest sufficient, or should it be set on just the config, or both for maximum cross-tool portability? Can a maintainer weigh in with some suggestions (ideally in the form of a implementation-note PR ;)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants