Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcontainer/specconv/spec_linux: Add support for (no)acl #1463

Closed
wants to merge 1 commit into from

Conversation

wking
Copy link
Contributor

@wking wking commented May 26, 2017

Part of catching runC up with the spec, which punts valid options to mount(8). Part of opencontainers/runtime-spec#771.

This is a filesystem-specific entry in mount(8), but it's represented by a MS_* flag in mount(2) so we need an entry in the translation table.

Part of catching runC up with the spec, which punts valid options to
mount(8) [1,2].  This is a filesystem-specific entry in mount(8), but
it's represented by a MS_* flag in mount(2) so we need an entry in the
translation table.

[1]: https://github.com/opencontainers/runtime-spec/blame/v1.0.0-rc5/config.md#L68
[2]: opencontainers/runtime-spec#771

Signed-off-by: W. Trevor King <[email protected]>
@wking
Copy link
Contributor Author

wking commented May 26, 2017

I'm not sure why Travis is unhappy. It looks like the tests passed on Go 1.8 but failed on 1.7 and tip with a checkpoint --pre-dump and restore issue? Is that test reliable?

@wking
Copy link
Contributor Author

wking commented May 26, 2017

Rolled into #1460 at @cyphar's request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant