Schema: update readme for how to validate manually #1141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liubin
requested review from
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
mrunalp,
tianon and
vbatts
as code owners
liubin
force-pushed
the
add-gomod-flag-for-schma-validate
branch
from
5829e93 to
711f50a
Compare
liubin
changed the title
tianon
approved these changes
Mar 10, 2022
schema/README.md
Outdated
| @@ -24,8 +24,8 @@ To build it: | |||
|
|
|||
| ```bash | |||
| export GOPATH=`mktemp -d` | |||
There was a problem hiding this comment.
Maybe we should add it here instead?
Suggested change
| export GOPATH=`mktemp -d` | |
| export GOPATH=`mktemp -d` GO111MODULE=off |
There was a problem hiding this comment.
@tianon I have updated as your suggestion.
BTW Makefile has the same issue but GitHub workflow calls go mod init before calling make validate.
liubin
force-pushed
the
add-gomod-flag-for-schma-validate
branch
from
711f50a to
8c2e788
Compare
The latest go is using gomod, but the repo has no go.mod, adding GO111MODULE=off to disable gomod and build it locally. Signed-off-by: bin liu <[email protected]>
liubin
force-pushed
the
add-gomod-flag-for-schma-validate
branch
from
8c2e788 to
8d66aac
Compare
tianon
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest go is using gomod, but the repo has no go.mod,
adding GO111MODULE=off to disable gomod and build it locally.
Signed-off-by: bin liu [email protected]