Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from kserve:master #151

Closed
wants to merge 33 commits into from
Closed

Conversation

pull[bot]
Copy link

@pull pull bot commented Dec 19, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

Jooho and others added 9 commits December 8, 2023 14:22
* Add CA bundle configuration

Signed-off-by: Danilo Peixoto <[email protected]>

* Implement CA bundle volume mount

Signed-off-by: Danilo Peixoto <[email protected]>

* Update tests

Signed-off-by: Danilo Peixoto <[email protected]>

* Add default mount path

Signed-off-by: Danilo Peixoto <[email protected]>

* Update defaults

Signed-off-by: Danilo Peixoto <[email protected]>

* Update constants

Signed-off-by: Danilo Peixoto <[email protected]>

* Use constant

Signed-off-by: Danilo Peixoto <[email protected]>

* Implement tests

Signed-off-by: Danilo Peixoto <[email protected]>

* Rename volume

Signed-off-by: Danilo Peixoto <[email protected]>

* Fix name references

Signed-off-by: Danilo Peixoto <[email protected]>

* Update configmap

Signed-off-by: Danilo Peixoto <[email protected]>

* fix unit test for pr-3216

Signed-off-by: jooho <[email protected]>

* add a logic to mount cabundle secret to storage-initializer container

Signed-off-by: jooho <[email protected]>

* Correct failed conflict resolve of storage_initializer_injector.go

Signed-off-by: Christian Kadner <[email protected]>

* Revert changes in go.sum

Signed-off-by: Christian Kadner <[email protected]>

* Revert changes in zz_generated.deepcopy.go

Signed-off-by: Christian Kadner <[email protected]>

* Revert changes in openapi_generated.go

Signed-off-by: Christian Kadner <[email protected]>

* Revert changes in zz_generated.deepcopy.go

Signed-off-by: Christian Kadner <[email protected]>

* convert Secret to ConfigMap for cabundle

Signed-off-by: jooho <[email protected]>

* update some sources to solve reviews

Signed-off-by: jooho <[email protected]>

* Add 'cabundle_configmap' to 'storage-config' StorageSpec

Signed-off-by: jooho <[email protected]>

* fix new comments

Signed-off-by: jooho <[email protected]>

* update to fix review comments

Signed-off-by: jooho <[email protected]>

---------

Signed-off-by: Danilo Peixoto <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Signed-off-by: jooho <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Jooho Lee <[email protected]>
Co-authored-by: Danilo Peixoto <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
Co-authored-by: Christian Kadner <[email protected]>
* Update Istio-Dex docs

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Add docs for auth using service account

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Fix kfserving name 

Signed-off-by: Dan Sun <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
…rror in future (#3272)

* Update ray serve version
Update tests to remove detached=false parameter

Signed-off-by: Andrews Arokiam <[email protected]>

* Pinned `async-timeout` as direct dependency for python 3.11

Signed-off-by: Andrews Arokiam <[email protected]>

---------

Signed-off-by: Andrews Arokiam <[email protected]>
* Fix qpext hangs during shutdown

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Fix e2e qpext image build

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Revert vcs info stamping

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
chore: Upgrade to XGBoost v2.0.2

Signed-off-by: Yuan Tang <[email protected]>
@openshift-ci openshift-ci bot requested review from Jooho and Xaenalt December 19, 2023 02:48
Copy link

openshift-ci bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pull[bot]
Once this PR has been reviewed and has the lgtm label, please assign xaenalt for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Dec 19, 2023

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pull pull bot removed the needs-rebase label Dec 20, 2023
* fix: Check if HPA has the same scaleTargetRef

Signed-off-by: Yuan Tang <[email protected]>

* Update pkg/controller/v1beta1/inferenceservice/reconcilers/hpa/hpa_reconciler.go

Co-authored-by: Jooho Lee <[email protected]>
Signed-off-by: Yuan Tang <[email protected]>

* chore: simplify semanticHPAEquals

Signed-off-by: Yuan Tang <[email protected]>

* chore: simplify

Signed-off-by: Yuan Tang <[email protected]>

---------

Signed-off-by: Yuan Tang <[email protected]>
Co-authored-by: Jooho Lee <[email protected]>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pull pull bot removed the needs-rebase label Dec 28, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…ixes #3314 (#3315)

* build: Switch to use kustomize in kubectl to simplify build process. Fixes #3314

Signed-off-by: Yuan Tang <[email protected]>

* Update scripts in hack folder

Signed-off-by: Yuan Tang <[email protected]>

* Address comments

Signed-off-by: Yuan Tang <[email protected]>

* Revert incorrect change

Signed-off-by: Yuan Tang <[email protected]>

---------

Signed-off-by: Yuan Tang <[email protected]>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

terrytangyuan and others added 3 commits December 29, 2023 21:07
* feat: Expose defaults for several batcher handler parameters

Signed-off-by: Yuan Tang <[email protected]>

* fix: add timeout

Signed-off-by: Yuan Tang <[email protected]>

* Add new params to config/manifests

Signed-off-by: Yuan Tang <[email protected]>

* Remove timeout

Signed-off-by: Yuan Tang <[email protected]>

---------

Signed-off-by: Yuan Tang <[email protected]>
…ixes #3323 (#3321)

* fix: Properly close resources and handle errors in agent and storage

Signed-off-by: Yuan Tang <[email protected]>

* reduce indentation

Signed-off-by: Yuan Tang <[email protected]>

* return early

Signed-off-by: Yuan Tang <[email protected]>

* return -> break

Signed-off-by: Yuan Tang <[email protected]>

* Address comments

Signed-off-by: Yuan Tang <[email protected]>

* newError -> closeErr

Signed-off-by: Yuan Tang <[email protected]>

* newError -> closeErr

Signed-off-by: Yuan Tang <[email protected]>

---------

Signed-off-by: Yuan Tang <[email protected]>
* Update bert tokenizer example

Signed-off-by: Dan Sun <[email protected]>

* Generate id for infer request

Signed-off-by: Dan Sun <[email protected]>

* Fix model name in tests

Signed-off-by: Dan Sun <[email protected]>

* Fix model_name argument

Signed-off-by: Dan Sun <[email protected]>

* Fix predictor_protocol

Signed-off-by: Dan Sun <[email protected]>

* Generate request id if none 

Signed-off-by: Dan Sun <[email protected]>

* Set default None for PredictorConfig

Signed-off-by: Dan Sun <[email protected]>

* Add comment

Signed-off-by: Dan Sun <[email protected]>

* Enable doc with default values

Signed-off-by: Dan Sun <[email protected]>

* Add back add_help false 

Signed-off-by: Dan Sun <[email protected]>

* Update protocol choices

Signed-off-by: Dan Sun <[email protected]>

* Fix grpc-v2 choice

Signed-off-by: Dan Sun <[email protected]>

---------

Signed-off-by: Dan Sun <[email protected]>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pull pull bot removed the needs-rebase label Dec 31, 2023
* Update kserve python runtime API docstring

Signed-off-by: Dan Sun <[email protected]>

* Use InferenceError

Signed-off-by: Dan Sun <[email protected]>

---------

Signed-off-by: Dan Sun <[email protected]>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spolti
Copy link
Member

spolti commented Jan 3, 2024

replaced by #159
due the conflicts, we can't fix it directly into community/master.

@spolti spolti closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.