Reverts of unneeded commits; and upstream code sync #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve#3371) Signed-off-by: jooho <[email protected]>
…ve#3363) * generate docs Signed-off-by: Yuan Tang <[email protected]> * fix Signed-off-by: Yuan Tang <[email protected]> * fix Signed-off-by: Yuan Tang <[email protected]> --------- Signed-off-by: Yuan Tang <[email protected]>
1. graph poetry project was not included in previous checks.
2. As poetry lock --check is deprecated, used `poetry check --lock`.
Signed-off-by: Andrews Arokiam <[email protected]>
* initial commit for graph raw deployment Signed-off-by: Mopuri, Bharath <[email protected]> Signed-off-by: Tanvi Thakur <[email protected]> * addd hpa support as well for inference graph raw deployment Signed-off-by: Mopuri, Bharath <[email protected]> Signed-off-by: Tanvi Thakur <[email protected]> * Just for local Signed-off-by: Mopuri, Bharath <[email protected]> Signed-off-by: Tanvi Thakur <[email protected]> * Just local Signed-off-by: Mopuri, Bharath <[email protected]> Signed-off-by: Tanvi Thakur <[email protected]> * Fix local setup Signed-off-by: Mopuri, Bharath <[email protected]> Signed-off-by: Tanvi Thakur <[email protected]> * Sleep change Signed-off-by: Mopuri, Bharath <[email protected]> Signed-off-by: Tanvi Thakur <[email protected]> * Fix self-signed-ca installation (kserve#3165) Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Signed-off-by: Mopuri, Bharath <[email protected]> Signed-off-by: Tanvi Thakur <[email protected]> * refactored Signed-off-by: Mopuri, Bharath <[email protected]> Signed-off-by: Tanvi Thakur <[email protected]> * Fix logging message Signed-off-by: Mopuri, Bharath <[email protected]> Signed-off-by: Tanvi Thakur <[email protected]> * adding unit tests Signed-off-by: Mopuri, Bharath <[email protected]> Signed-off-by: Tanvi Thakur <[email protected]> * adding unit tests Signed-off-by: Mopuri, Bharath <[email protected]> Signed-off-by: Tanvi Thakur <[email protected]> * removed temporary dev env changes Signed-off-by: Mopuri, Bharath <[email protected]> Signed-off-by: Tanvi Thakur <[email protected]> * Rawdeployment mode type Signed-off-by: Mopuri, Bharath <[email protected]> Signed-off-by: Tanvi Thakur <[email protected]> * restoring from master branch Signed-off-by: Mopuri, Bharath <[email protected]> Signed-off-by: Tanvi Thakur <[email protected]> * Remove affinity test Signed-off-by: Tanvi Thakur <[email protected]> * add with resource test Signed-off-by: Tanvi Thakur <[email protected]> * added controller test for graph Signed-off-by: Mopuri, Bharath <[email protected]> * addressed code review comments Signed-off-by: Mopuri, Bharath <[email protected]> * Added copy right statement for new files Signed-off-by: Mopuri, Bharath <[email protected]> * Removed dependency for InferenceGraph kind on componentExtensionSpec which is specific to inference service spec Signed-off-by: Mopuri, Bharath <[email protected]> * restored Makefile from master branch Signed-off-by: Mopuri, Bharath <[email protected]> * fixed codescan issue for AtoI function Signed-off-by: Mopuri, Bharath <[email protected]> * fixed test failures Signed-off-by: Mopuri, Bharath <[email protected]> * Added unit test for hpa reconciler Signed-off-by: Mopuri, Bharath <[email protected]> * Added Ready status when Deployment is available in raw mode Signed-off-by: Mopuri, Bharath <[email protected]> * Removed unused code Signed-off-by: Mopuri, Bharath <[email protected]> * e2e test for ISVC in raw mode Signed-off-by: Mopuri, Bharath <[email protected]> * improved e2e tests for inference graph raw deployment Signed-off-by: Mopuri, Bharath <[email protected]> * fixed python lint errors Signed-off-by: Mopuri, Bharath <[email protected]> * added annotations for ig spec that triggers raw deployment Signed-off-by: Mopuri, Bharath <[email protected]> * made names unique b/w runs Signed-off-by: Mopuri, Bharath <[email protected]> * Add test Signed-off-by: Tanvi Thakur <[email protected]> * Adding unit test Signed-off-by: Tanvi Thakur <[email protected]> * fixed e2e test failure for ig. IG is not moving to ready state because of not handling raw deployment mode condition correctly Signed-off-by: Mopuri, Bharath <[email protected]> * changed marker for graph test Signed-off-by: Mopuri, Bharath <[email protected]> * corrected test validation for raw deployment mode knative resources Signed-off-by: Mopuri, Bharath <[email protected]> * correct rebase errors Signed-off-by: Mopuri, Bharath <[email protected]> * hpa field moved from annotations to inferencegraphspec as fields Signed-off-by: Mopuri, Bharath <[email protected]> * commiting make generate output due to InferenceGraphSpec changes Signed-off-by: Mopuri, Bharath <[email protected]> --------- Signed-off-by: Mopuri, Bharath <[email protected]> Signed-off-by: Tanvi Thakur <[email protected]> Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Co-authored-by: Mopuri, Bharath <[email protected]> Co-authored-by: Tanvi Thakur <[email protected]> Co-authored-by: Sivanantham <[email protected]>
When Istio is installed with its CNI plugin, KServe inference services are not capable to start. This is because the storage initializer is an init-container and the network is not available when the CNI plugin is enabled. The typical recommendation to fix the issue is to remove init-containers and move any initialization code to a regular container. This approach would not work well with KServe, because the serving runtimes assume the model is already present on the filesystem and moving the storage initializer as a regular container will cause race conditions (the runtime will succeed loading only if the storage initializer manages to pull the model before the runtime starts). There are alternative approaches documented in https://istio.io/latest/docs/setup/additional-setup/cni/#compatibility-with-application-init-containers. All alternatives have the downside that the traffic won't be captured by Istio and won't benefit from Istio features, which should be OK for KServe storage-initializer case. These changes use the approach for running the storage initializer using the same UserID as the Istio sidecar. The UID is copied from the sidecar container to cover Istio derivatives, like Maistra. Signed-off-by: Edgar Hernández <[email protected]>
This reverts commit 17fb6b9. Signed-off-by: Edgar Hernández <[email protected]>
…-cni" This reverts commit 4e7f0df Signed-off-by: Edgar Hernández <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
israel-hdez
changed the title
openshift-merge-bot
bot
merged commit f462609
into
opendatahub-io:master
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This reverts the following PRs that are no longer need:
The PR also does a code-sync with the upstream repository. Without the sync, kserve#3316 would not be picked and CI tests would be failing. So, the reverts and the sync need to be done at the same time to ensure stability.
Which issue(s) this PR fixes:
This is the remainder work to close: https://issues.redhat.com/browse/RHOAIENG-1084.
Feature/Issue validation/testing:
CI E2E tests should be enough to ensure correctness of the build.