Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI: Serverless removed domain-mapping deployment #277

Merged

Conversation

israel-hdez
Copy link

What this PR does / why we need it:

In Serverless version 1.32.0, the domain-mapping deployment no longer exists. This updates the deploy.serverless.sh script used in openshift-ci to no longer wait for this deployment.

In Serverless version 1.32.0, the `domain-mapping` deployment no longer exists. This updates the deploy.serverless.sh script used in openshift-ci to no longer wait for this deployment.

Signed-off-by: Edgar Hernández <[email protected]>
@openshift-ci openshift-ci bot requested review from Jooho and spolti March 22, 2024 16:06
@spolti
Copy link
Member

spolti commented Mar 22, 2024

/approve

Copy link

openshift-ci bot commented Mar 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spolti
Copy link
Member

spolti commented Mar 22, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a3f7d15 into opendatahub-io:master Mar 22, 2024
28 checks passed
@israel-hdez israel-hdez deleted the ci-fix-serverless-1320 branch March 22, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants