[RHOAIENG-5073] - Routing and Headless Service Support in KServe Raw Mode Deployment #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Mode Deployment Signed-off-by: Spolti <[email protected]>
Signed-off-by: Spolti <[email protected]>
spolti
requested review from
Jooho
and removed request for
davidesalerno and
terrytangyuan
Signed-off-by: Spolti <[email protected]>
| envtest: $(ENVTEST) ## Download envtest-setup locally if necessary. | ||
| $(ENVTEST): $(LOCALBIN) | ||
| test -s $(LOCALBIN)/setup-envtest || GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest | ||
| test -s $(LOCALBIN)/setup-envtest || GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@$(ENVTEST_PACKAGE_VERSION) |
There was a problem hiding this comment.
without it CI fails, same as here:
opendatahub-io/odh-model-controller#184
|
/test |
|
@spolti: No presubmit jobs available for opendatahub-io/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spolti, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 7bc82f2
into
opendatahub-io:release-v0.11.1
20 checks passed
xieshenzh
pushed a commit
to xieshenzh/kserve
that referenced
this pull request
Jul 11, 2024
onboarding kserv 2.10 on konflux
israel-hdez
added a commit
to israel-hdez/kserve
that referenced
this pull request
Mar 11, 2025
This fixes a regression, because in ODH the Services had been headless for Raw deployment mode (see opendatahub-io#288). Such default changed to headed services when the feasibility to configure the behavior was introduced, but despite the upstream project has always been using headed services, in ODH this breaks backwards compatibility. Thus, this restores the ODH default of using headless services for Raw deployment. Users can still use the inferenceservice-config ConfigMap to switch to headed Services. Signed-off-by: Edgar Hernández <[email protected]>
israel-hdez
added a commit
to israel-hdez/kserve
that referenced
this pull request
Mar 11, 2025
This fixes a regression, because in ODH the Services had been headless for Raw deployment mode (see opendatahub-io#288). Such default changed to headed services when the feasibility to configure the behavior was introduced, but despite the upstream project has always been using headed services, in ODH this breaks backwards compatibility. Thus, this restores the ODH default of using headless services for Raw deployment. Users can still use the inferenceservice-config ConfigMap to switch to headed Services. Signed-off-by: Edgar Hernández <[email protected]>
1 task
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
This fixes a regression, because in ODH the Services had been headless for Raw deployment mode (see #288). Such default changed to headed services when the feasibility to configure the behavior was introduced, but despite the upstream project has always been using headed services, in ODH this breaks backwards compatibility. Thus, this restores the ODH default of using headless services for Raw deployment. Users can still use the inferenceservice-config ConfigMap to switch to headed Services. Signed-off-by: Edgar Hernández <[email protected]>
israel-hdez
added a commit
to israel-hdez/kserve
that referenced
this pull request
Mar 13, 2025
This fixes a regression, because in ODH the Services had been headless for Raw deployment mode (see opendatahub-io#288). Such default changed to headed services when the feasibility to configure the behavior was introduced, but despite the upstream project has always been using headed services, in ODH this breaks backwards compatibility. Thus, this restores the ODH default of using headless services for Raw deployment. Users can still use the inferenceservice-config ConfigMap to switch to headed Services. Signed-off-by: Edgar Hernández <[email protected]>
israel-hdez
added a commit
to israel-hdez/kserve
that referenced
this pull request
Mar 13, 2025
This fixes a regression, because in ODH the Services had been headless for Raw deployment mode (see opendatahub-io#288). Such default changed to headed services when the feasibility to configure the behavior was introduced, but despite the upstream project has always been using headed services, in ODH this breaks backwards compatibility. Thus, this restores the ODH default of using headless services for Raw deployment. Users can still use the inferenceservice-config ConfigMap to switch to headed Services. Signed-off-by: Edgar Hernández <[email protected]>
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
This fixes a regression, because in ODH the Services had been headless for Raw deployment mode (see #288). Such default changed to headed services when the feasibility to configure the behavior was introduced, but despite the upstream project has always been using headed services, in ODH this breaks backwards compatibility. Thus, this restores the ODH default of using headless services for Raw deployment. Users can still use the inferenceservice-config ConfigMap to switch to headed Services. Signed-off-by: Edgar Hernández <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks #280