Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from kserve:master #379

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented Jun 19, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

* refactor into smaller methods

Signed-off-by: grandbora <[email protected]>

* address comments

Signed-off-by: grandbora <[email protected]>

* format

Signed-off-by: grandbora <[email protected]>

---------

Signed-off-by: grandbora <[email protected]>
Copy link

openshift-ci bot commented Jun 19, 2024

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sivanantha321 and others added 4 commits June 19, 2024 11:26
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
…ge types (#3735)

* Refactor storage initializer to log model download time for all storage types

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Add more tests for local storage

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
* Add nccl and flash_attn dependencies for huggingface runtime

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Fix vllm generate argument

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Upgrade to cuda 12.4

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Copy link
Member

@spolti spolti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pull[bot], spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4c52716 into opendatahub-io:master Jun 19, 2024
9 checks passed
rpancham pushed a commit to rpancham/kserve that referenced this pull request Jun 25, 2024
This reverts commit 4c52716, reversing
changes made to 3065fd4.
rpancham pushed a commit to rpancham/kserve that referenced this pull request Jun 25, 2024
This reverts commit 4c52716, reversing
changes made to 3065fd4.
rpancham pushed a commit to rpancham/kserve that referenced this pull request Jun 25, 2024
This reverts commit 4c52716, reversing
changes made to 3065fd4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants