Fix apiGroups in aggregate roles on manifests #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the aggregate roles were using `kubeflow.org` in the API groups, which is incorrect. This fixes the manifests to use the right API group. Signed-off-by: Edgar Hernández <[email protected]>
openshift-ci
bot
requested review from
terrytangyuan and
VedantMahabaleshwarkar
3 tasks
israel-hdez
requested review from
spolti and
Jooho
and removed request for
terrytangyuan and
VedantMahabaleshwarkar
spolti
approved these changes
Aug 21, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, spolti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Aug 26, 2024
spolti
referenced
this pull request
in spolti/kserve
Sep 16, 2024
…updates/kserve-controller-211 Update kserve-controller-211 to 730f664
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the aggregate roles were using
kubeflow.orgin the API groups, which is incorrect.This fixes the manifests to use the right API group.
Related to opendatahub-io/odh-model-controller#255