[RHOAIENG-12260] - [konflux] hermetic build for storage-initializer i… #411
Conversation
…s failing chore: Fix error: No available modular metadata for modular package Signed-off-by: Spolti <[email protected]>
openshift-ci
bot
requested review from
terrytangyuan and
VedantMahabaleshwarkar
spolti
removed request for
terrytangyuan,
VedantMahabaleshwarkar and
riprasad
|
From jira ticket, it looks like the changes fix the build issue with PoC branch. So it looks good to me, but I don't know the option |
will need to update the poetry locks. |
|
Can we bring the |
|
Not sure, odh and upstream are too much different, we would need to do it separately later. |
|
/retest |
|
Then, it is probably better to re-align with upstream in another effort. I don't understand why ODH needs to be that different, specially in the python projects we don't support. In other matters... can you elaborate on why we need to update the lockfiles for this PR? The Dockerfile change looks unrelated. |
spolti
force-pushed
the
RHOAIENG-12260
branch
from
88a2d9f to
48301c4
Compare
|
I read somewhere in the CI logs that it was complaining about the locks, looks like I was wrong :) |
There was a problem hiding this comment.
Now that it is minimal, I happy with it.
@Jooho the module_hotfixes name seems to be misleading. Looks like it is simply to allow dnf using non-module packages. This slack thread gives a good explanation: https://serverfault.com/a/1016865.
I guess in hermetic builds, module metadata is not made available to the builder and dnf is failing because of that... And such flag simply fixes it..... but I'm guessing here.
I'm, anyway, approving. But I'll let Jooho give the final check.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, spolti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
You are right @israel-hdez. |
|
@israel-hdez Thanks for the information! Actually, whether to use modules or non-modules isn't that important. I'm unsure if it would have any impact on security, so the key concern for me is whether it's acceptable to the Konflux team or not. @spolti do you know who can review this change from konflux team? |
|
@MohammadiIram or @riprasad from DevOps can help to review as well. |
|
With the conversation with Konflux team, they gave us this feedback. So I am ok with this change. |
openshift-merge-bot
bot
merged commit 4add27b
into
opendatahub-io:master
…s failing (opendatahub-io#411) chore: Fix error: No available modular metadata for modular package Signed-off-by: Spolti <[email protected]>
…s failing (#411) (#416) chore: Fix error: No available modular metadata for modular package Signed-off-by: Spolti <[email protected]> Co-authored-by: Filippe Spolti <[email protected]>
…s failing
chore: Fix error: No available modular metadata for modular package
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note:
Re-running failed tests
/rerun-all- rerun all failed workflows./rerun-workflow <workflow name>- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.