forked from kserve/kserve
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add oauth-proxy to rawdeployments if odh auth label is present #419
Merged
israel-hdez
merged 20 commits into
opendatahub-io:master
from
VedantMahabaleshwarkar:j-10306
Dec 9, 2024
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
e97ec96
add oauth-proxy to rawdeployments if odh auth label is present
VedantMahabaleshwarkar bb253d6
remove ingress modifications
VedantMahabaleshwarkar c6ade9b
bug fix
VedantMahabaleshwarkar 79fd6d5
consume oauth proxy params from configmap
VedantMahabaleshwarkar 970938d
fix oauth proxy sar and minor bugs
VedantMahabaleshwarkar 6b3f7af
revert some unneeded changes
VedantMahabaleshwarkar 6abba54
add oauth proxy flag to prevent login page redirect on invalid request
VedantMahabaleshwarkar 8028a3b
address feedback
VedantMahabaleshwarkar b506272
update to newer oauth proxy image
VedantMahabaleshwarkar 57543a8
minor fix
VedantMahabaleshwarkar 1b26421
fix unit test
VedantMahabaleshwarkar 3c21d1c
more feedback
VedantMahabaleshwarkar fbbc15f
cookie secret
VedantMahabaleshwarkar a5e9643
test and other fixes
VedantMahabaleshwarkar efbfed1
fix lint issues
VedantMahabaleshwarkar 4160784
address latest feedback
VedantMahabaleshwarkar a2d6562
missed import sort
VedantMahabaleshwarkar 8a3c76b
address more feedback
VedantMahabaleshwarkar 0aa3eee
bug fix
VedantMahabaleshwarkar 96f4b7d
fix lint error
VedantMahabaleshwarkar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if we should do this, can. Could you please elaborate on why this might be needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to fetch the routes to update the isvc status with the correct URL since the route is created by ODH Model Controller. So we have to add the route api to the scheme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any resource can be fetched without it, still not sure why it is really needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without this the controller throws errors along the lines of "no kind for "Route" registered"