Code sync for upstream v0.14.0 #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* propagate trc bool across vllm init Signed-off-by: Calvin Woo <[email protected]> Signed-off-by: calvin d. woo <[email protected]> * use args directly to avoid undefined var Signed-off-by: Calvin Woo <[email protected]> Signed-off-by: calvin d. woo <[email protected]> * Remove trailing space Signed-off-by: Dan Sun <[email protected]> Signed-off-by: calvin d. woo <[email protected]> * move params to newline Signed-off-by: calvin d. woo <[email protected]> --------- Signed-off-by: Calvin Woo <[email protected]> Signed-off-by: calvin d. woo <[email protected]> Signed-off-by: Dan Sun <[email protected]> Co-authored-by: Dan Sun <[email protected]>
The KServe Python SDK README.md uses relative URLs that work well on GitHub but return a 404 error when visited on PyPI. This change updates the README.md to use absolute URLs that work well on both GitHub and PyPI. Signed-off-by: kevinbazira <[email protected]>
check empty model final. Signed-off-by: HAO <[email protected]> Co-authored-by: koshino17 <[email protected]>
* Fix No model ready error in multi model serving - Fixes the regression introduced by kserve#3275 Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Mark transformer model ready in init method Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
* Initial implementation of inference client Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Add tests Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Use Inference client for e2e tests Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Upgrade pytest-asyncio to 0.23.4 Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Fix mutable object initialization in default parameters Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Fix graph e2e tests Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Fix pmml test Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Add explain, support dict response, use inference client for internal requests Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Fix inference graph test and grpc headers Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Remove v1 datamodels Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Introduce protocol in client config Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Support inference graph Signed-off-by: Sivanantham Chinnaiyan <[email protected]> remove logging configs Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Update default timeout to 60 seconds Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Add retry config for grpc client Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Fix infer model_name parameter Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Add tests for graph endpoint Signed-off-by: Sivanantham Chinnaiyan <[email protected]> debug Signed-off-by: Sivanantham Chinnaiyan <[email protected]> fix http client param mismatch Signed-off-by: Sivanantham Chinnaiyan <[email protected]> skip graph test Signed-off-by: Sivanantham Chinnaiyan <[email protected]> fix timeout in grpc client Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Fix url construction Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Fix explain Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * configure logger for e2e tests Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Rebase master Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Rebase master Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Fix grpc retry config Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Increase request timeout Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * configure logger for e2e tests Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Rebase master Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Rebase master Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Fix grpc retry config Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Increase request timeout Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Rebase Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Use fixtures for rest client Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
* Fix model name not properly parsed by inference graph Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Handle single string arg with excess whitespace Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Handle duplicate arguments Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Signed-off-by: Dan Sun <[email protected]> Co-authored-by: Dan Sun <[email protected]>
empty commit Signed-off-by: Spolti <[email protected]>
Use add_generation_rompt for chat template Signed-off-by: Dattu Sharma <[email protected]>
* Deduplicate the names for the additional domain names Signed-off-by: Vincent Hou <[email protected]> * Refactoring the functions Signed-off-by: Vincent Hou <[email protected]> --------- Signed-off-by: Vincent Hou <[email protected]>
virtual service case insensitive Signed-off-by: Andrews Arokiam <[email protected]>
* Install packages needed for model load Signed-off-by: Gavrish Prabhu <[email protected]> * make all apt get into a single line Signed-off-by: Gavrish Prabhu <[email protected]> --------- Signed-off-by: Gavrish Prabhu <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
…serve#3789) * Add readiness probe for mlserver in CI Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Increase memory limit for pmml test to prevent OOMKilled and read timeout error Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
* Fix logprobs Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Fix a scenario where stream completion fails if echo is true and logprobs is nil Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Fix a scenario where completion fails if the prompt is token_ids and echo is set to true Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Respect tokenizer revision Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Add workaround for adding None to token_logprobs and top_logprobs Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
agent watcher unit test is always flaky so increase timeout to make it stable Signed-off-by: jooho lee <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
* Add tests for vLLM Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * resolve comments Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Uncomment tests for fixed bugs Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
….3 (kserve#3812) * Upgrade serving runtime python version to 3.11 and debian to bookworm Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Upgrade poetry to 1.8.3 Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Upgrade openjdk to 17 for pmml Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Fix 'AS' casing warning Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Fix pmml server Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
* Bump vLLM to 0.5.3.post1 Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Update makefile Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * approx probability comparison Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Set multiprocessing method to spawn Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
…se 'spawn' for mutiprocessing (kserve#3757) * Refactor model server to let uvicorn handle multiple workers - Refactored the ModelServer to let uvicorn handle multiple workers. This will remove the bottleneck of using 'fork' for multiprocessing - Make FastAPI app instance easily accessible across the project so that users can easily add middlewares and custom exception handlers for custom models. - Use uvloop eventpolicy Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Add middleware example Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Add e2e test Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Remove nest_asyncio in art explainer Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Remove uvloop Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Rebase master Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Fix python tests Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * revert art explainer Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Remove monkeypatch Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Remove redundant future exception logging Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Spolti <[email protected]>
* Make ray serve an optional dependency Signed-off-by: Curtis Maddalozzo <[email protected]> Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Unify the log configuration using kserve logger (kserve#3577) * Configure logging for serving runtimes Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Add pyyaml dependency Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * black format Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * fix pyproject.toml Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Rebase master Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * cleanup logger for e2e Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Modify logger format to include func name Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Log model download time. Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Rebase master Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Allow disabling logger configuration and deprecate logger related arg in model server Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Rebase master Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Resolve comments Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * pyyaml=^6.0.0 to fix build failure Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Remove logger related parameters from model server Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * import model_server Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Fix lint Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Fix linting Signed-off-by: Curtis Maddalozzo <[email protected]> Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Rebase, minor fixes and add e2e test Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Curtis Maddalozzo <[email protected]> Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Co-authored-by: Curtis Maddalozzo <[email protected]> Co-authored-by: Dan Sun <[email protected]>
* Update aif example chore: Update aif explainer example. - Bump KServer to 0.13.0, it will bring some library updates, plus, it fixes a few security alerts in this example. - update the scikit-learn package name Signed-off-by: Spolti <[email protected]> * move the local instructions to the README Signed-off-by: Spolti <[email protected]> * empty commit Signed-off-by: Spolti <[email protected]> --------- Signed-off-by: Spolti <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
…ve#3737) These changes introduce the possibility to configure KServe with its own Istio local gateway, to partially decouple KServe from the Knative local gateway. Typically, it is OK to re-use the already configured Knative local gateway for KServe uses (as long as configs do not conflict). However, there are cases where having a dedicated local gateway for KServe is beneficial. Just to give some examples: * To have the ability to use strict mTLS in Istio * To reduce some pressure on the Knative local gateway by having a dedicated gateway deployment (it still would hit Knative gateway, but only once, rather than twice) * To be able to configure TLS on cluster-local hostnames (Knative support is still experimental) To have a dedicated Gateway in KServe, similar configurations to Knative are need to be done. At the very least, and if not having a dedicated gateway deployment, a v1/Service and an Istio Gateway resource need to be created for KServe. Such resources would need to be configured in _localGateway_ and _localGatewayService_. KServe still needs to rely on Knative routing for the KSVCs it creates. Thus, after handling an incoming request and resolving its target, it needs to be forwarded to be handled by Knative. This is the reason for introducing a new `knativeLocalGatewayService` in the ConfigMap. The removed `ingressService` seems to be unused. Apparently, it became unused when the v1alpa1 API of the InferenceServices was deprecated and removed. Signed-off-by: Edgar Hernández <[email protected]>
* Add support for Azure DNS zone endpoints Signed-off-by: tjandy98 <[email protected]> * Add test cases for Azure Blob and File Share URI pattern matching Signed-off-by: tjandy98 <[email protected]> * flake8 Signed-off-by: tjandy98 <[email protected]> * black Signed-off-by: tjandy98 <[email protected]> --------- Signed-off-by: tjandy98 <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
* Add logging request feature for vLLM Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Add log request feature for huggingface Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
* Consolidate into one commit Signed-off-by: Jin Dong <[email protected]> * Fix configmap format Signed-off-by: Jin Dong <[email protected]> * Fix configmap Signed-off-by: Jin Dong <[email protected]> * Log configmap read error Signed-off-by: Jin Dong <[email protected]> * fix naming Signed-off-by: Dan Sun <[email protected]> * Update comments Signed-off-by: Jin Dong <[email protected]> * Add enabled flag to configmap and avoid cluster resource check in isvc defaulter Signed-off-by: Jin Dong <[email protected]> * move client into the local model block Signed-off-by: Dan Sun <[email protected]> * Fix lint Signed-off-by: Jin Dong <[email protected]> --------- Signed-off-by: Jin Dong <[email protected]> Signed-off-by: Dan Sun <[email protected]> Co-authored-by: Dan Sun <[email protected]>
* Sync helm chart with kustomize Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Update manifest generation script to sync helm charts Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Make kserve-addressable-resolver role optional Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Prepare for 0.14.0-rc1 release Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Update release process Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Comment out crd sync script in make Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Fix helm template syntax Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
* add a new API for multi-node/multi-gpu Signed-off-by: jooho lee <[email protected]> * fix gitaction Signed-off-by: jooho lee <[email protected]> * fix merging conflict Signed-off-by: jooho lee <[email protected]> * fix gitaction fail Signed-off-by: jooho lee <[email protected]> * regenerate codegen/manifests Signed-off-by: jooho lee <[email protected]> * Apply suggestions from code review Co-authored-by: Dan Sun <[email protected]> Signed-off-by: Jooho Lee <[email protected]> * remove unnecessary comment Signed-off-by: jooho lee <[email protected]> * change the type of workerSpec in isvc to PodSpec Signed-off-by: jooho lee <[email protected]> * update controller-gen version Signed-off-by: jooho lee <[email protected]> * remove replicas from workerSpec Signed-off-by: jooho lee <[email protected]> * fix conflict merging Signed-off-by: jooho lee <[email protected]> * added size(replicas) for workerSpec again Signed-off-by: jooho lee <[email protected]> * add WorkerSpec to inferenceService Signed-off-by: jooho lee <[email protected]> * fix go linter Signed-off-by: jooho lee <[email protected]> --------- Signed-off-by: jooho lee <[email protected]> Signed-off-by: Jooho Lee <[email protected]> Signed-off-by: Jooho Lee <[email protected]> Co-authored-by: Dan Sun <[email protected]>
…#3924) * fix openapigen.sh that can be executed from kserve dir Signed-off-by: jooho lee <[email protected]> * regenerate codegen/manifests Signed-off-by: jooho lee <[email protected]> * Update go.sum Signed-off-by: Dan Sun <[email protected]> --------- Signed-off-by: jooho lee <[email protected]> Signed-off-by: Dan Sun <[email protected]> Co-authored-by: Dan Sun <[email protected]>
* Support python 3.12 Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Update dependencies Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Update deps to support 3.12 Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Remove python 3.8 support Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Remove skip for infer client test Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Fix port forward Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Fix sklearn pandas dep Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * skip pydantic v1 test for py 3.12 Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Add setuptools dep for pmml Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Fix lgb Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Include setuptools for paddle Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Include setuptools for huggingface Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Rebase Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Rebase Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
* Bump version to 0.13.0-rc0 (kserve#3665) Signed-off-by: Curtis Maddalozzo <[email protected]> Signed-off-by: jordanyono <[email protected]> * fixing docs Signed-off-by: jordanyono <[email protected]> * fix spelling mistake Signed-off-by: jordanyono <[email protected]> --------- Signed-off-by: Curtis Maddalozzo <[email protected]> Signed-off-by: jordanyono <[email protected]> Co-authored-by: Curtis Maddalozzo <[email protected]>
* Fix local testing Signed-off-by: Dan Sun <[email protected]> * Fix codegen Signed-off-by: Dan Sun <[email protected]> --------- Signed-off-by: Dan Sun <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
* Add a flag for automount serviceaccount Signed-off-by: Jin Dong <[email protected]> * Set default to false Signed-off-by: Jin Dong <[email protected]> * Default to true Signed-off-by: Jin Dong <[email protected]> * Fix test error Signed-off-by: Jin Dong <[email protected]> * Update openapi generated.go Signed-off-by: Jin Dong <[email protected]> * Fix python lint Signed-off-by: Jin Dong <[email protected]> * Fix config loading Signed-off-by: Jin Dong <[email protected]> --------- Signed-off-by: Jin Dong <[email protected]>
…ainer (kserve#3985) * Do not set security context on the storage initializer from user container Signed-off-by: Jin Dong <[email protected]> * Add securityContext to the default storage container in the helm chart Signed-off-by: Jin Dong <[email protected]> --------- Signed-off-by: Jin Dong <[email protected]>
This adds the model container as an init-container to mitigate a race condition that would happen if the model container is not present on the cluster-node. The race condition happens if the cluster is able to fetch and start the runtime container before the modelcar is fetched. This would lead to the runtime to terminate with error. By configuring the model container as an init-container the runtime won't start until the modelcar is fetched. Although there is still the risk of a race condition when the cluster schedules the runtime container first, the pod should stabilize after a few restarts of the runtime container and should either prevent a CrashLoopBackOff event on the pod, or the crash event would finish quickly. This improves compatibility with the runtimes which can now stay agnostic to the modelcar implementation, until better techniques (like native sidecars, and oci volume mounts) become mature. Signed-off-by: Edgar Hernández <[email protected]>
* Initial commit for headers passing issue Signed-off-by: Andrews Arokiam <[email protected]> * modifying the e2e test for rebase conflict Signed-off-by: Andrews Arokiam <[email protected]> * bug fix on unittest Signed-off-by: Andrews Arokiam <[email protected]> * review changes Signed-off-by: Andrews Arokiam <[email protected]> * fix for test failure Signed-off-by: Andrews Arokiam <[email protected]> * bug fix on e2e test Signed-off-by: Andrews Arokiam <[email protected]> * overridding the entrypoint of custom model images Signed-off-by: Andrews Arokiam <[email protected]> * custom response header Signed-off-by: Andrews Arokiam <[email protected]> * fix for unittest failure Signed-off-by: Andrews Arokiam <[email protected]> * added custom response headers in post process Signed-off-by: Andrews Arokiam <[email protected]> * added predict time latency in example response header Signed-off-by: Andrews Arokiam <[email protected]> * fix OOM --------- Signed-off-by: Andrews Arokiam <[email protected]> Co-authored-by: Dan Sun <[email protected]>
* security update Signed-off-by: udai <[email protected]> * adding sign off Signed-off-by: udai <[email protected]> --------- Signed-off-by: udai <[email protected]>
Signed-off-by: Jin Dong <[email protected]>
* temp commit Signed-off-by: Jin Dong <[email protected]> * python-release.sh Signed-off-by: Jin Dong <[email protected]> --------- Signed-off-by: Jin Dong <[email protected]>
…14-upgrade Code sync with upstream, up to v0.14. Signed-off-by: Edgar Hernández <[email protected]>
Signed-off-by: Edgar Hernández <[email protected]>
Signed-off-by: Edgar Hernández <[email protected]>
israel-hdez
force-pushed
the
j9436-kserve014-upgrade
branch
from
18c0f1b to
b7a868f
Compare
spolti
approved these changes
Oct 25, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, spolti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@israel-hdez: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.