-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues after 0.14.0 sync #424
Conversation
010847f
to
933e3c7
Compare
config/crd/external/datasciencecluster.opendatahub.io_datascienceclusters.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is deactivating several E2Es. Can we have the list of the ones that would be ran? (i.e. a screenshot of the PASSED ones)
config/crd/external/datasciencecluster.opendatahub.io_datascienceclusters.yaml
Show resolved
Hide resolved
Signed-off-by: jooho lee <[email protected]>
Signed-off-by: jooho lee <[email protected]>
Signed-off-by: jooho lee <[email protected]>
Signed-off-by: jooho lee <[email protected]>
Signed-off-by: jooho lee <[email protected]>
0bf0316
to
a12727e
Compare
Signed-off-by: jooho lee <[email protected]>
a12727e
to
04c9695
Compare
@Jooho: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, Jooho, spolti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* remove patch for webhookconfiguration Signed-off-by: jooho lee <[email protected]> * comment out localmodel for now, this need to be reverted Signed-off-by: jooho lee <[email protected]> * add dsc/dsci objects for e2e test Signed-off-by: jooho lee <[email protected]> * fix e2e test Signed-off-by: jooho lee <[email protected]> * follow up comments Signed-off-by: jooho lee <[email protected]> * fix e2e test after latest sync Signed-off-by: jooho lee <[email protected]> --------- Signed-off-by: jooho lee <[email protected]>
What this PR does / why we need it:
webhookconfiguration
to fix kustomize build issue.predictor
,path_based_routing
,raw
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Special notes for your reviewer:
Checklist:
Release note:
Re-running failed tests
/rerun-all
- rerun all failed workflows./rerun-workflow <workflow name>
- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.