Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues after 0.14.0 sync #424

Merged
merged 6 commits into from
Nov 4, 2024
Merged

Conversation

Jooho
Copy link

@Jooho Jooho commented Oct 29, 2024

What this PR does / why we need it:

  • remove patch for webhookconfiguration to fix kustomize build issue.
  • fix e2e tests for predictor, path_based_routing, raw

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • kustomize issue
kustomize build ./config/overlay/odh
kustomize build ./config/overlay/test
  • e2e test
 ./test/scripts/openshift-ci/run-e2e-tests.sh path_based_routing
 ./test/scripts/openshift-ci/run-e2e-tests.sh predictor ./test/scripts/openshift-ci/run-e2e-tests.sh predictor
 ./test/scripts/openshift-ci/run-e2e-tests.sh raw
  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:


Re-running failed tests

  • /rerun-all - rerun all failed workflows.
  • /rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

Copy link

@israel-hdez israel-hdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is deactivating several E2Es. Can we have the list of the ones that would be ran? (i.e. a screenshot of the PASSED ones)

@Jooho Jooho force-pushed the 0.14_sync_issues branch 5 times, most recently from 0bf0316 to a12727e Compare November 4, 2024 15:53
Copy link

openshift-ci bot commented Nov 4, 2024

@Jooho: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-raw 04c9695 link true /test e2e-raw
ci/prow/e2e-fast 04c9695 link true /test e2e-fast
ci/prow/e2e-slow 04c9695 link true /test e2e-slow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@spolti
Copy link
Member

spolti commented Nov 4, 2024

/approve
/lgtm

Copy link

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, Jooho, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jooho,israel-hdez,spolti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jooho Jooho merged commit 9f46725 into opendatahub-io:master Nov 4, 2024
22 of 28 checks passed
Jooho added a commit to Jooho/kserve that referenced this pull request Nov 4, 2024
* remove patch for webhookconfiguration

Signed-off-by: jooho lee <[email protected]>

* comment out localmodel for now, this need to be reverted

Signed-off-by: jooho lee <[email protected]>

* add dsc/dsci objects for e2e test

Signed-off-by: jooho lee <[email protected]>

* fix e2e test

Signed-off-by: jooho lee <[email protected]>

* follow up comments

Signed-off-by: jooho lee <[email protected]>

* fix e2e test after latest sync

Signed-off-by: jooho lee <[email protected]>

---------

Signed-off-by: jooho lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants