[v0.14] Enable forwarding Authorization header in InferenceGraphs #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will configure all `InferenceGraph` workloads to forward the standard HTTP `Authorization` header to the backing `InferenceServices`. The `Authorization` header is used to receive/send credentials and let ODH stack to validate access. By enabling forwarding of the `Authorization` header, we cover the case when there is an (some) auth-protected InferenceService(s) as part of an InferenceGraph. Access is fine-grained, so access to an InferenceGraph does not guarantee access to some InferenceService. The user needs to provide credentials to all resources (IGs and ISVC) that the request needs to go through. Since each workload validates credentials on its own, credentials need to be forwarded to all workloads of an InferenceGraph. Signed-off-by: Edgar Hernández <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
israel-hdez
commented
Jan 16, 2025
| "cpuLimit": "1", | ||
| "headers": { | ||
| "propagate": [ | ||
| "Authorization" |
There was a problem hiding this comment.
@Jooho @danielezonca Please, advice if this is fine.
I don't see an issue as long as everything runs over TLS.
There was a problem hiding this comment.
I think it is a good idea to add token to downstream endpoints.
israel-hdez
requested review from
Jooho and
danielezonca
and removed request for
terrytangyuan and
mholder6
|
|
|
/lgtm |
openshift-merge-bot
bot
merged commit bce3a4e
into
opendatahub-io:release-v0.14
20 checks passed
israel-hdez
added a commit
to israel-hdez/kserve
that referenced
this pull request
Jan 22, 2025
…b-io#467) This will configure all `InferenceGraph` workloads to forward the standard HTTP `Authorization` header to the backing `InferenceServices`. The `Authorization` header is used to receive/send credentials and let ODH stack to validate access. By enabling forwarding of the `Authorization` header, we cover the case when there is an (some) auth-protected InferenceService(s) as part of an InferenceGraph. Access is fine-grained, so access to an InferenceGraph does not guarantee access to some InferenceService. The user needs to provide credentials to all resources (IGs and ISVC) that the request needs to go through. Since each workload validates credentials on its own, credentials need to be forwarded to all workloads of an InferenceGraph. Signed-off-by: Edgar Hernández <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This will configure all
InferenceGraphworkloads to forward the standard HTTPAuthorizationheader to the backingInferenceServices.The
Authorizationheader is used to receive/send credentials and let ODH stack to validate access.By enabling forwarding of the
Authorizationheader, we cover the case when there is an (some) auth-protected InferenceService(s) as part of an InferenceGraph. Access is fine-grained, so access to an InferenceGraph does not guarantee access to some InferenceService. The user needs to provide credentials to all resources (IGs and ISVC) that the request needs to go through. Since each workload validates credentials on its own, credentials need to be forwarded to all workloads of an InferenceGraph.Which issue(s) this PR fixes
Fixes https://issues.redhat.com/browse/RHOAIENG-17827
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Checklist: