On InferenceService deletion, validate no references to it #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spolti
reviewed
Jan 29, 2025
@spolti Yes. This is the reason for doing it here, instead of |
spolti
reviewed
Jan 29, 2025
spolti
reviewed
Jan 29, 2025
InferenceGraphs can reference InferenceServices to create an inference pipeline using multiple models. Deleting an InferenceService that is being referenced by an InferenceGraph can turn unusable the InferenceGraph. This adds a validation to prevent deletion of InferenceServices that are being used in InferenceGraphs. Signed-off-by: Edgar Hernández <[email protected]>
israel-hdez
force-pushed
the
j17829-prevent-deleting-referenced-isvcs
branch
from
7a7931b to
5e17418
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, spolti, VedantMahabaleshwarkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 5325636
into
opendatahub-io:release-v0.14
20 checks passed
@spolti Proposed to upstream: kserve#4235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
InferenceGraphs can reference InferenceServices to create an inference pipeline using multiple models. Deleting an InferenceService that is being referenced by an InferenceGraph can turn unusable the InferenceGraph.
This adds a validation to prevent deletion of InferenceServices that are being used in InferenceGraphs.
Fixes https://issues.redhat.com/browse/RHOAIENG-17829
Type of changes
Feature/Issue validation/testing:
Checklist: