Ability to configure Raw InferenceGraphs as private #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
israel-hdez
force-pushed
the
j20324-private-raw-ig
branch
from
1599b51 to
db7b831
Compare
Jooho
reviewed
Mar 7, 2025
israel-hdez
force-pushed
the
j20324-private-raw-ig
branch
from
db7b831 to
d410067
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, VedantMahabaleshwarkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This adds the possibility to use the `networking.kserve.io/visibility=cluster-local` label to configure an InferenceGraph in Raw mode as private (not exposed). Signed-off-by: Edgar Hernández <[email protected]>
israel-hdez
force-pushed
the
j20324-private-raw-ig
branch
from
d410067 to
bb89560
Compare
|
/retest |
|
/lgtm |
openshift-merge-bot
bot
merged commit 8837d5f
into
opendatahub-io:release-v0.14
27 checks passed
israel-hdez
added a commit
to israel-hdez/kserve
that referenced
this pull request
Mar 14, 2025
This adds the possibility to use the `networking.kserve.io/visibility=cluster-local` label to configure an InferenceGraph in Raw mode as private (not exposed). Signed-off-by: Edgar Hernández <[email protected]>
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Mar 14, 2025
This adds the possibility to use the `networking.kserve.io/visibility=cluster-local` label to configure an InferenceGraph in Raw mode as private (not exposed). Signed-off-by: Edgar Hernández <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds the possibility to use the
networking.kserve.io/visibility=cluster-locallabel to configure an InferenceGraph in Raw mode as private (not exposed).Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):https://issues.redhat.com/browse/RHOAIENG-20324
Type of changes
Please delete options that are not relevant.
masterbranch.Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
networking.kserve.io/visibility=cluster-locallabel to the InferenceGraph. Then, check that the route is removed.Checklist:
masterbranch.