-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-19717] Pod now has correct imagepull secret when updated in raw deployment #522
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
4ca5a36
to
93a74dd
Compare
c00967a
to
181c53f
Compare
pkg/controller/v1beta1/inferenceservice/reconcilers/deployment/deployment_reconciler.go
Outdated
Show resolved
Hide resolved
017bd4b
to
a6d925d
Compare
/retest |
/retest |
/rerun-all |
Signed-off-by: Andres Llausas <[email protected]> Signed-off-by: Andres Llausas <[email protected]>
f2f8704
to
1d50681
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andresllh, brettmthompson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This issue was found while using Modelcars feature. For Modelcars, users may prefer using a private container registry to store their models. When using a private registry, it is required to provide a pull secret in the InferenceService so that the cluster can pull the model container.
At any time, and for any reason, users may require to replace/update the pull secret. This operation is done on the InferenceService. It is observed that when replacing the pull secret, the old one won't be removed in the updated deployment.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
RHOAIENG-19717
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Special notes for your reviewer:
Checklist:
Release note:
Re-running failed tests
/rerun-all
- rerun all failed workflows./rerun-workflow <workflow name>
- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.