Populate Elyra runtime images configMap from runtime images imagestream manifests and mounts it on the Notebook CR

[atheo89]

Related to: https://issues.redhat.com/browse/RHOAIENG-19051

Related PRs for this workload:
New set of runtime ImageStreams: opendatahub-io/notebooks#930
Unwire .json files from the Datascience Notebook: opendatahub-io/notebooks#909

Description

This PR add a new notebook_runtime script where includes the logic to create/watch/update a new ConfigMap the pipeline-runtime-images from the runtime images imagesStreams (related PR) and mount it as volume with the name /opt/app-root/pipeline-runtimes/ on the notebook CR when is getting created.

NOTE: We don't make a use of devFlag for this feature, as it doesn't seem to have any issue with Applications -> Embeded-> JupyterLab spinup notebook

How Has This Been Tested?

1. Update the RHOAI DSC with the following:

    workbenches:
      devFlags:
        manifests:
          - contextDir: components/odh-notebook-controller/config
            sourcePath: ''
            uri: 'https://github.com/atheo89/kubeflow/archive/rhoaieng-19050-configmap-generator.tar.gz'
          - contextDir: manifests
            sourcePath: ''
            uri: 'https://github.com/opendatahub-io/notebooks/archive/main.tar.gz'
      managementState: Managed
      

2. Import the quay.io/rh_ee_atheodor/workbench-images@sha256:f2bc105afab97575007a5743e39cc4c045fa276ba8612b6a8241758d48711913 notebook (Includes the changes from this PR) This is a notebook without the .json runtimes in it.

3. Spin up this Custom Datascience notebook via UI
   Click on the left side menu and click this icon.
   

You should see the runtimes mounted like below:

On the Back-end side:
4. Inspect the logs on the odh-notebook-controller to find the related logs on the configMap creation and the mounting, like below.

...
{"level":"info","ts":"2025-02-20T10:13:31Z","logger":"controllers.Notebook","msg":"Created new ConfigMap for runtime images","namespace":"atheo","ConfigMap.Name":"pipeline-runtime-images"}
...
{"level":"info","ts":"2025-02-20T10:13:31Z","logger":"controllers.Notebook","msg":"Injecting runtime-images volume into notebook","notebook":"t1","namespace":"atheo","notebook":"t1","namespace":"atheo"}
...

5. Check on the notebook pod statefullset for the config map, press on it to inspect also the data from this configMap
   

6. Check as well on the notebook CR to evaluate the mounting, as is on the bellow image:
   

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from atheo89. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[atheo89]

/hold
Until investigate if we have any issue with notebook tile

[atheo89]

Just rebased the PR, sorry Jiri for ping you again for your review :P
Rest folks, please take a look once you are available

[jiridanek]

/lgtm

I'm going to trust you on this being just a rebase

don't see anything suspicious

normally I'd check https://github.com/opendatahub-io/kubeflow/compare/a5bf7efc2d06ba74dd6f5b79e06a0e92ee1af3fe..db27716ce20f463529ebeef0c50cddfbca1b7779 but there is 250k lines changed since PR was opened ;{

[atheo89]

/lgtm
I'm going to trust you on this being just a rebase

Thanks again Jiri, basicaly nothing strange happened on my end when i did rebase, looks that i got all the changes moreover, the commit that you added about the ImageStreams dropped while the rebase, because the one from Wen was merged.
Plus i don't bring double commits after the rebase, as i see from this UI view there are only the changes related to this PR.

[harshad16]

Great work 🎉

Left one question.

Testing the following scenarios:

• On upgrade, existing notebook are not touched: ✔️
• Existing notebook on restart, are not attached with rutimes: ✔️
• New notebook on creation are attached with runtimes: ✔️
• New notebook with old image are attached with runtimes, however they are not used by elyra and stay in separate dir: ✔️
• Creation of imagestream in ods-application, updates configamp: ✔️
• edit of configmap in username , reconciles the configmap: ✔️

Pending the testing, i need to check these in jupyter tile
(due to shortage of time , couldn't check, will check soon and provide final review)

[openshift-ci]

New changes are detected. LGTM label has been removed.