Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-18401, RHOAIENG-18402: chore(.tekton/): Red Hat Konflux update odh-notebook-controller Pipelines as Code configuration proposal #532

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

red-hat-konflux[bot]
Copy link

Pipelines as Code configuration proposal

To start the PipelineRun, add a new comment with content /ok-to-test

For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun

To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Copy link

openshift-ci bot commented Feb 26, 2025

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.13%. Comparing base (d109b88) to head (411a665).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #532   +/-   ##
=======================================
  Coverage   54.13%   54.13%           
=======================================
  Files           9        9           
  Lines        2335     2335           
=======================================
  Hits         1264     1264           
  Misses        974      974           
  Partials       97       97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiridanek
Copy link
Member

/ok-to-test

@jiridanek jiridanek changed the title Red Hat Konflux update odh-notebook-controller RHOAIENG-18401, RHOAIENG-18402: chore(.tekton/): Red Hat Konflux update odh-notebook-controller Pipelines as Code configuration proposal Feb 26, 2025
@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels Feb 26, 2025
@jiridanek
Copy link
Member

/lgtm
/approve

This should be a much better approach towards

First, merge the konflux-autogenerated code as is, and then make changes. The default-generated pipeline is already quite appropriate for us.

Copy link

openshift-ci bot commented Feb 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit aef4bb9 into main Feb 26, 2025
21 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the appstudio-odh-notebook-controller branch February 26, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants