Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pytest tutorial #894

Open
wants to merge 2 commits into
base: refactor/konflux-migration
Choose a base branch
from

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Feb 10, 2025

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Feb 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jiridanek. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the size/l label Feb 10, 2025
@jstourac
Copy link
Member

Thank you for this, Jiri. But I'm wondering - do we really want this as part of this repository? 🤔 Wouldn't some links to an existing tutorial be enough? 🤔 From the current content, it looks like you plan to extend this. How big do you want this to be?

@jiridanek
Copy link
Member Author

Thank you for this, Jiri. But I'm wondering - do we really want this as part of this repository? 🤔

I originally wanted to do this already in https://github.com/skodjob/odh-e2e. I was learning how to do things with the fabric8 client and this is imo a good way to keep notes,

Wouldn't some links to an existing tutorial be enough? 🤔

The advantage of doing it this way is that whoever reads it can immediately run the sample tests and modify the code. It can be useful when writing a new test and wanting to use some sample code to start from.

From the current content, it looks like you plan to extend this. How big do you want this to be?

Pytest basics (essentially what's there already), and kubernetes-py basics, and ocp_resources basics.

@openshift-ci openshift-ci bot added size/l and removed size/l labels Feb 23, 2025
@jiridanek jiridanek added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 23, 2025
@openshift-ci openshift-ci bot added size/l and removed size/l labels Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/l tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants