-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-18400: chore(konflux): Red Hat Konflux update jupyter-minimal-ubi9-python-3-11 #931
RHOAIENG-18400: chore(konflux): Red Hat Konflux update jupyter-minimal-ubi9-python-3-11 #931
Conversation
Signed-off-by: red-hat-konflux <[email protected]>
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@jiridanek just to be clear - what happens once we merge this? We'll be getting the konflux builds for the minimal ubi9 image? both PR and both for each merged commit, is that correct? |
Yes, exactly that. Also we'll run enterprise contract on the build result. It adds the two Konflux ci jobs (build+ec) that are listed on this pr already. |
I'm all for it. If all goes well, we'll add the rest of our images, right? And if so, then we can use the konflux repo and it's clair report to check the software installed on each image... can't wait. /lgtm |
We'll also need to add paths for trigger, so that it's not building
everything every pull request. Not sure whether such limiting for pushes
may be desirable too.
edit:
* #938
…On Mon, Mar 3, 2025, 12:00 Jan Stourac ***@***.***> wrote:
I'm all for it. If all goes well, we'll add the rest of our images, right?
And if so, then we can use the konflux repo and it's clair report to check
the software installed on each image... can't wait.
/lgtm
—
Reply to this email directly, view it on GitHub
<#931 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADMCYHIUJBGP24LP57MJY32SQYY3AVCNFSM6AAAAABYDG7RS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJTHE4TINZRHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: jstourac]*jstourac* left a comment (opendatahub-io/notebooks#931)
<#931 (comment)>
I'm all for it. If all goes well, we'll add the rest of our images, right?
And if so, then we can use the konflux repo and it's clair report to check
the software installed on each image... can't wait.
/lgtm
—
Reply to this email directly, view it on GitHub
<#931 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADMCYHIUJBGP24LP57MJY32SQYY3AVCNFSM6AAAAABYDG7RS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJTHE4TINZRHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-18400
This is (hopefully) to be a better start than my previous
At this point (after the multistage dockerfile restructuring) the autogenerated PR from Konflux is in a working state from the start, so we can merge that pipeline unchanged.
Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content
/ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization