Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-18400: chore(konflux): Red Hat Konflux update jupyter-minimal-ubi9-python-3-11 #931

Merged

Conversation

red-hat-konflux[bot]
Copy link
Contributor

@red-hat-konflux red-hat-konflux bot commented Feb 28, 2025

https://issues.redhat.com/browse/RHOAIENG-18400

This is (hopefully) to be a better start than my previous

At this point (after the multistage dockerfile restructuring) the autogenerated PR from Konflux is in a working state from the start, so we can merge that pipeline unchanged.

Pipelines as Code configuration proposal

To start the PipelineRun, add a new comment with content /ok-to-test

For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun

To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Copy link
Contributor

openshift-ci bot commented Feb 28, 2025

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek jiridanek added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. ok-to-test and removed needs-ok-to-test labels Feb 28, 2025
@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels Feb 28, 2025
@jiridanek jiridanek changed the title Red Hat Konflux update jupyter-minimal-ubi9-python-3-11 RHOAIENG-18400: chore(konflux): Red Hat Konflux update jupyter-minimal-ubi9-python-3-11 Feb 28, 2025
@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels Feb 28, 2025
@jstourac
Copy link
Member

jstourac commented Mar 3, 2025

@jiridanek just to be clear - what happens once we merge this? We'll be getting the konflux builds for the minimal ubi9 image? both PR and both for each merged commit, is that correct?

@jiridanek
Copy link
Member

We'll be getting the konflux builds for the minimal ubi9 image? both PR and both for each merged commit, is that correct?

Yes, exactly that. Also we'll run enterprise contract on the build result. It adds the two Konflux ci jobs (build+ec) that are listed on this pr already.

@jstourac
Copy link
Member

jstourac commented Mar 3, 2025

I'm all for it. If all goes well, we'll add the rest of our images, right? And if so, then we can use the konflux repo and it's clair report to check the software installed on each image... can't wait.

/lgtm

@jiridanek
Copy link
Member

jiridanek commented Mar 3, 2025 via email

@jiridanek
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Mar 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 5, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 58e788d into main Mar 5, 2025
31 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the appstudio-jupyter-minimal-ubi9-python-3-11 branch March 5, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test size/xxl tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants