-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-19478, RHOAIENG-19715, RHOAIENG-19485 - Explore versions compatibility, upgrade Jupyter packages and upgrade Runtime images #946
base: main
Are you sure you want to change the base?
Conversation
For this point:
we should coordinate with @caponetto And as Adriel mentioned on scrum we can bring the fix on a fast upcoming release |
30fe79c
to
78262c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any updates being made to /manifests files, please also update versions of packages in manifests. Or is that a separate Jira task?
@jiridanek There is a separated task: https://issues.redhat.com/browse/RHOAIENG-19486 |
Yes and no, some packages yes they related with trustyai itself but some others nolike for example: https://github.com/opendatahub-io/notebooks/blob/main/jupyter/trustyai/ubi9-python-3.11/Pipfile#L30C1-L30C6 did you try to updated and you faced conflict with trusty itself? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hey, I did a couple of changes:
pending:
again: any suggestion, concern, feedback, they are all really appreciated. thanks! |
@daniellutz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Daniel, apart of the pending items that you have already listed, i noticed that may we need to update jupyterlab-git dependency as well.
This PR aims to solve three issues:
Description
Based on the research of packages that could and should be upgraded, these are the versions that could be upgraded without generating conflicts on Pipfile.lock files.
The Runtime images changes were planned to be present on another PR, but since there are many similarities with the Explore versions and Update JupyterLab changes, it has been added here as well to ease the readability.
There were some limitations, or some changes that are a little bit different from previous package versions:
Tensorflow on ROCm:
Tensorflow on CUDA:
tensorflow-rocm
package (that is locked on version 2.14.0.600 since January 2024) with a ROCm wheel repository, as follows:https://rocm.docs.amd.com/projects/install-on-linux/en/latest/install/3rd-party/tensorflow-install.html#using-a-wheels-package
torch = {version = "~=2.4.0", index = "pytorch"}
, but now they require the local version identifier -torch = {version = "==2.6.0+rocm6.2.4", index = "pytorch"}
Besides that, the vast majority of packages were successfully upgraded without major problems.
TrustyAI wasn't updated because it maintains its libraries with specific versions, not requiring an upgrade unless necessary.
How Has This Been Tested?
The test has been done by building the notebook images locally and running them with Podman, as follows:
For each one of the following images, the instructions below have been executed:
Notebook images:
Instructions
make
command:Example:
Example:
Merge criteria: