Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cuda): Upgrade all cuda-related IDE workbences to CUDA 12.6 #949

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

andyatmiami
Copy link
Contributor

Description

As part of the 2025a release - we want to bump CUDA to the (latest) 12.6.3 version.

This work builds upon the excellent investigation of @daniellutz to bring the upgrade to fruition.

A couple important points to note:

  • Previously RStudio and Jupyter were on different version of CUDA (12.1 and 12.4 respectively). This change standardizes the version to 12.6 across the IDEs
  • The .repo and licence file previously stored in cuda subfolders for ubi9 and c9s are identical. To avoid unnecessary duplication - the files are now at the root of the cuda/ directory - and sub-folders have been removed.
  • There is some uncertainty on whether or not ENV XLA_FLAGS needs to be defined. For now, for consistency, it is always placed as the last instruction in the cuda-base Docker stage prior to restoring USER + WORKDIR to desired values.

Related-to: https://issues.redhat.com/browse/RHOAIENG-19480

How Has This Been Tested?

⚠️ Testing is currently a work in progress

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

As part of the `2025a` release - we want to bump CUDA to the (latest) `12.6.3` version.

This work builds upon the excellent investigation of @daniellutz to bring the upgrade to fruition.

A couple important points to note:
- Previously RStudio and Jupyter were on different version of CUDA (`12.1` and `12.4` respectively).  This change standardizes the version to `12.6` across the IDEs
- The `.repo` and licence file previously stored in `cuda` subfolders for `ubi9` and `c9s` are identical.  To avoid unnecessary duplication - the files are now at the root of the `cuda/` directory - and sub-folders have been removed.
- There is some uncertainty on whether or not `ENV XLA_FLAGS` needs to be defined.  For now, for consistency, it is always placed as the last instruction in the `cuda-base` Docker stage prior to restoring `USER` + `WORKDIR` to desired values.

Related-to: https://issues.redhat.com/browse/RHOAIENG-19480
this commit SHOULD NOT (necessarily) be committed.. will need rework to make sure changes don't disrupt normal development workflow
Copy link
Contributor

openshift-ci bot commented Mar 14, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign paulovmr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants