fix: catch fetch error on clone_from

opendatateam · Jun 3, 2024 · ac817ee · ac817ee
1 parent e638a58
commit ac817ee
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/src/custom/ecospheres/utils/bouquet.ts b/src/custom/ecospheres/utils/bouquet.ts
@@ -105,14 +105,14 @@ export function useExtras(topic: Ref<Topic | null>): {
     subtheme.value = topic.value?.extras['ecospheres:informations'][0].subtheme
     datasetsProperties.value =
       topic.value?.extras['ecospheres:datasets_properties'] ?? []
-    // FIXME: catch 404 when possible from data.gouv.fr
     if (topic.value?.extras?.ecospheres?.cloned_from != null) {
       useTopicStore()
-        .load(topic.value?.extras.ecospheres.cloned_from)
+        .load(topic.value?.extras.ecospheres.cloned_from, { toasted: false })
         .then((res) => {
           clonedFrom.value = res
         })
-        .catch(() => {
+        .catch((err) => {
+          console.error('Failed fetching cloned_from', err.response?.data)
           clonedFrom.value = null
         })
     } else {

diff --git a/src/model/api.ts b/src/model/api.ts
@@ -45,7 +45,7 @@ export interface RequestConfig extends CustomParams {
 
 export type URLParams = Record<string, string | number | null>
 
-interface BaseParams extends CustomParams {
+export interface BaseParams extends CustomParams {
   headers?: Record<string, unknown>
 }
 

diff --git a/src/store/TopicStore.ts b/src/store/TopicStore.ts
@@ -2,6 +2,7 @@ import { defineStore } from 'pinia'
 import { computed, type ComputedRef } from 'vue'
 
 import config from '@/config'
+import type { BaseParams } from '@/model/api'
 import type { TopicConf } from '@/model/config'
 import type { Topic } from '@/model/topic'
 
@@ -116,10 +117,10 @@ export const useTopicStore = defineStore('topic', {
     /**
      * Get a single topic from store or API
      */
-    async load(slugOrId: string): Promise<Topic> {
+    async load(slugOrId: string, params?: BaseParams): Promise<Topic> {
       const existing = this.get(slugOrId)
       if (existing !== undefined) return existing
-      const topic = await topicsAPIv2.get({ entityId: slugOrId })
+      const topic = await topicsAPIv2.get({ entityId: slugOrId, ...params })
       this.data.push(topic)
       return topic
     },