Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditional import of indicator in bouquet #674

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

abulte
Copy link
Contributor

@abulte abulte commented Mar 4, 2025

Un couplage entre bouquet et indicateurs a été introduit dans #666.

Ce couplage pose problème sur les autres verticales qui utilise les bouquets (crash page bouquet sur météo par exemple).

Cette PR propose un import conditionnel des modules et composants nécessaires aux indicateurs seulement dans le cas d'Ecosphères.

@abulte abulte requested a review from streino March 4, 2025 08:46
Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for ecospheres ready!

Name Link
🔨 Latest commit b8e8cc5
🔍 Latest deploy log https://app.netlify.com/sites/ecospheres/deploys/67c6bdc6ba82300008b80240
😎 Deploy Preview https://deploy-preview-674--ecospheres.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for meteo-france ready!

Name Link
🔨 Latest commit b8e8cc5
🔍 Latest deploy log https://app.netlify.com/sites/meteo-france/deploys/67c6bdc6a291640008025e2a
😎 Deploy Preview https://deploy-preview-674--meteo-france.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abulte abulte merged commit 770f0a2 into main Mar 4, 2025
8 checks passed
@abulte abulte deleted the fix/indicator-in-bouquet-generic branch March 4, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants