Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dependency) upgrade grpc lib dependency to v1.34.2 #37

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

iyashu
Copy link
Contributor

@iyashu iyashu commented Mar 23, 2021

Why is this PR required? What issue does it fix?:
Upgrading the grpc dependency to v1.34.2 since external provisioner itself using higher version.
It's being pointed out by @akhilerm under devide-localpv pull request comment openebs-archive/device-localpv#5 (comment)

What this PR does?:
Upgrade grpc dependency to v1.34.2. Additionally as mentioned in above comment due to breaking changes from upstream, I've fix the compilation prob under lvm/volume.go by replacing status.FromContextError(ctx.Err()) to status.FromContextError(ctx.Err()).Err().

Does this PR require any upgrade changes?:
No

If the changes in this PR are manually verified, list down the scenarios covered::
NA

Any additional information for your reviewer? :
NA

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@praveengt praveengt merged commit 06e59b5 into openebs:master Mar 23, 2021
Copy link
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants