Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-context metrics for studio #1030

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

tecoholic
Copy link

@tecoholic tecoholic commented Mar 10, 2025

Description

This PR adds the necessary config to enable In-context metrics for Studio (Authoring MFE).

Testing Instructions

This should be tested alongside openedx/frontend-app-authoring#1725 (or after it has been merged).

  1. Clone the repo and checkout the PR branch
  2. In your existing tutor environment, install the plugin with pip install -e <path-to-the-clone>
  3. Run tutor config save to update the MFE config.
  4. Setup frontend-app-authoring as per feat: adds slots for in-context metrics in studio outline and unit views frontend-app-authoring#1725
  5. Run tutor dev launch to update the environment. Or make sure to build the authoring mfe (tutor images build authoring-dev) before restarting the tutor environment.

This will load your local copy of the Authoring MFE onto the container. So, copy the env.config.jsx from the tutor environment manually to your repo clone.

Example:

cp $(tutor config printroot)/env/plugins/mfe/build/mfe/env.config.jsx /path/to/frontend-app-authoring

Now the Authoring MFE should show the "Analytics" button on the header

image

Disabling in-context metrics components

The in-context metrics components can be disabled using a tutor configuration. Run the following to test that.

tutor config save --set ASPECTS_ENABLE_STUDIO_IN_CONTEXT_METRICS=False

Now copy the env.config.jsx again and check the MFE.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 10, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 10, 2025

Thanks for the pull request, @tecoholic!

This repository is currently maintained by @bmtcril.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@tecoholic tecoholic changed the title [WIP] In-context metrics for studio In-context metrics for studio Mar 11, 2025
@tecoholic tecoholic marked this pull request as ready for review March 11, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

2 participants