Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: align aspects folder structure #105

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Jun 28, 2023

Description

Refactor the folder structure for Aspects so it's more maintainable

@Ian2012 Ian2012 requested a review from bmtcril June 28, 2023 15:20
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 28, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 Ian2012 force-pushed the cag/refactor-folder-structure branch from 1abc0bf to 90d5b6f Compare June 28, 2023 15:21
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me, were you able to get this tested on k8s?

@Ian2012
Copy link
Contributor Author

Ian2012 commented Jun 28, 2023

No, our tests in k8s are blocked till we add backward compatibility to tutor 14

@Ian2012 Ian2012 merged commit 40ee54f into main Jun 28, 2023
@Ian2012 Ian2012 deleted the cag/refactor-folder-structure branch June 28, 2023 19:06
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants