Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the encoding arg for the stata reader #331

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove the encoding arg for the stata reader #331

wants to merge 1 commit into from

Conversation

pzuldp
Copy link

@pzuldp pzuldp commented Mar 10, 2025 •
edited
Loading

Technical changes

  • Remove an argument passed to the read_source function when the source is dta format, because the stata reader does not accept the argument

@pzuldp pzuldp requested review from benjello and clallemand March 10, 2025 17:38
@pzuldp pzuldp changed the title comment out the encoding arg for the stata reader remove the encoding arg for the stata reader Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjello benjello Awaiting requested review from benjello

@clallemand clallemand Awaiting requested review from clallemand

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pzuldp