Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mscratchcswl and mscratchcsw should operate on mscratch #589

Closed
Silabs-ArjanB opened this issue Jun 20, 2022 · 4 comments
Closed

mscratchcswl and mscratchcsw should operate on mscratch #589

Silabs-ArjanB opened this issue Jun 20, 2022 · 4 comments
Labels
Component:RTL For issues in the RTL (e.g. for files in the rtl directory) Status:Resolved Issue has been resolved, but closure is pending on git merge and/or issuer confirmation Type:Bug For bugs in any content (RTL, Documentation, etc.)

Comments

@Silabs-ArjanB
Copy link
Contributor

mscratchcswl and mscratchcsw are currently implemented as regular CSRs and not according to the pseudo code stated in the CLIC specification.

Take riscv/riscv-fast-interrupt#241 into account as well.
@Silabs-ArjanB Silabs-ArjanB added Component:RTL For issues in the RTL (e.g. for files in the rtl directory) Type:Bug For bugs in any content (RTL, Documentation, etc.) labels Jun 20, 2022
silabs-oysteink added a commit to silabs-oysteink/cv32e40x that referenced this issue Sep 7, 2022
@silabs-oysteink
Fix for issue openhwgroup#589.
a31e635 
Removed instances for mscratchcsw and mscratchcswl CSRs. These CSRs now conditioinally operate on mscratch according to the CLIC spec.

Signed-off-by: Oystein Knauserud <[email protected]>
silabs-oysteink added a commit that referenced this issue Sep 8, 2022
@silabs-oysteink
Merge pull request #661 from silabs-oysteink/silabs-oysteink_issue-589
118a05c 
Fix for issue #589.
@Silabs-ArjanB
Copy link
Contributor Author

@silabs-oysteink Has this been fixed now including the mentioned issue 241?

@silabs-oysteink
Copy link
Contributor

silabs-oysteink commented Oct 14, 2022 •
edited
Loading

Code is actually using mcause.mpp, so we are not compliant with the issue mentioned. Other than that everything should be in order.

@Silabs-ArjanB
Copy link
Contributor Author

@silabs-oysteink Should be a SEC clean change to get it fixed then; I will add it in the coming sprint.

@silabs-oysteink
Copy link
Contributor

This issue should now be fixed.

@silabs-oysteink silabs-oysteink added the Status:Resolved Issue has been resolved, but closure is pending on git merge and/or issuer confirmation label Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component:RTL For issues in the RTL (e.g. for files in the rtl directory) Status:Resolved Issue has been resolved, but closure is pending on git merge and/or issuer confirmation Type:Bug For bugs in any content (RTL, Documentation, etc.)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Silabs-ArjanB @silabs-oysteink