Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E40X 0.3.0 : Doc, Fixed mpie R/W attribute by @Silabs-ArjanB in #481 #599

Closed
eroom1966 opened this issue Jun 29, 2022 · 5 comments
Closed
Labels
Status:Resolved Issue has been resolved, but closure is pending on git merge and/or issuer confirmation Type:Question For general questions

Comments

@eroom1966
Copy link

In the Documentation Changes from 0.2.0 to 0.3.0, it says

Fixed mpie R/W attribute by @Silabs-ArjanB in #481

I cannot find any differences in the pdf documentation between 0.2.0 and 0.3.0 referring to mpie, could you please identify the difference in the text.

@Silabs-ArjanB
Copy link
Contributor

Please see the mentioned pull request: https://github.com/openhwgroup/cv32e40x/pull/481/files

@Silabs-ArjanB Silabs-ArjanB added Status:Resolved Issue has been resolved, but closure is pending on git merge and/or issuer confirmation Type:Question For general questions labels Jun 29, 2022
@Imperas
Copy link

Imperas commented Jul 1, 2022

The process for Imperas to update the 40X reference model is to rely on the specification as a frozen pdf, for example version 0.4.0 - and so we do not look at the RTL and we do not look at the documentation 'source' files - we build the model from the specification and so please ensure that the specification pdf is correct (and any changes to the source that creates it is propagated) as that what we rely on and all users will rely on. [After all the verification process if to compare the RTL to the reference model (via the spec)- so it makes no sense for the reference model just to copy potential errors in the RTL...]

To clarify - we look at the fixed versioned spec not pull requests to anything.

Also - the 40X spec should not have items/content in it that relates to other cores (e.g. 40S) - the 40X spec should define the 40X core. period.

So - please fix the pdf.

Also I would recommend the use of incremental changes eg 0.4.0->0.4.1 for changes to the doc that don't change the spec.

Simon

@Silabs-ArjanB
Copy link
Contributor

@Imperas The changelist is autogenerated and can therefore contain comments that do not actually apply to the specific core itself. Such non-applicable content does not impact (and is not visible in) the actual content (i.e. everything else than the autogenerated change list) of the pdf . If you would simply do a 'pdf diff' on two released versions of the user manual and ignore diffs in the change list itself, you will have an accurate overview of the changes.

There is not need for Imperas to look in the documentation source files or in the RTL files. Please let me know if this works for you. If not, then we will filter the change list going forward to exclude potentially misleading content.

We can agree to increment the 'patch' part of the version number for incremental changes that don't change the spec, but in reality that will not help you much as user manual releases are infrequent and bundle multiple changes (so the chance of there only being 'patch' releases in such bundle is very low).

@Silabs-ArjanB
Copy link
Contributor

Hello @eroom1966 Has this issue been answered properly? If so, can you please close the issue? Same question for issues 600-614.

@Silabs-ArjanB
Copy link
Contributor

@eroom1966 Can this ticket be closed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Resolved Issue has been resolved, but closure is pending on git merge and/or issuer confirmation Type:Question For general questions
Projects
None yet
Development

No branches or pull requests

3 participants